Make netcdf mandatory #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 3.9 runs fine since it install the second latest version of MIKEIO, which is missing the |
|
@ecomodeller could you please let us know why netcdf4 should be a required dependency to modelskill - I guess many users would be just fine with dfs and csv files and never use nc files? |
|
I think they want to save and load the Comparer instead of waiting to read the raw files each time. |
|
right - I forgot about save/load 😳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparer.load,Comparer.saveandComparerCollection.load,ComparerCollection.saveuses the NetCDF format for persistence.NetCDF is a standardized format, which will allow you to open these files in the future and with other software.
The collection uses a zip file of NetCDF files at least until PR #461 gets merged, when this will be a single file with groups similar to a file system.