Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw model data is PointModelResult #497

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Raw model data is PointModelResult #497

merged 1 commit into from
Jan 8, 2025

Conversation

ecomodeller
Copy link
Member

No description provided.

@ecomodeller ecomodeller linked an issue Jan 8, 2025 that may be closed by this pull request
Loading a saved Comparer/ComparerCollection restores raw-model-data as PointObservation #496
Closed
@jsmariegaard
Copy link
Member

Why was it TimeSeries in the first place? What was the benefit of that?

@jsmariegaard
Copy link
Member

Closes #496

@ecomodeller
Copy link
Member Author

I think the idea was to make clear that we are only relying on method in the TimeSeries class, which has fewer methods and attributes than the PointModelResult.

@ecomodeller ecomodeller merged commit f2acbd3 into main Jan 8, 2025
6 checks passed
@ecomodeller ecomodeller deleted the fix/raw_model_data branch January 8, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmariegaard jsmariegaard jsmariegaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading a saved Comparer/ComparerCollection restores raw-model-data as PointObservation
2 participants
@ecomodeller @jsmariegaard