Updates for Numpy, StickyDesign compatibility #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stickydesign 0.9.0.a2 is now compatible (reimplements fastsub in rust). - peppercompiler 0.1.4 (not yet released) fixes several file name problems
cgevans
commented
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow Piperine to work with more recent versions of Python (eg, 3.12) and Numpy (eg, 1.26). They also change the dependency requirements to use StickyDesign ≥ 0.8.4, which fixes a build problem for _stickyext with more recent Numpy versions, and automatically use the
fast=Falsepure-Python method in both Piperine energetics modules if _stickyext was still not built successfully.I'm currently waiting on confirmation that this works for other people.