Skip to content

Commit

Permalink
Merge pull request #181 from DNDACADEMY/develop
Browse files Browse the repository at this point in the history
perf(web): social icon 링크에 인식 가능한 이름 aria-label 적용 (#180)
  • Loading branch information
saseungmin authored Sep 4, 2024
2 parents 572a010 + 4c90170 commit 4dda66b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions apps/web/src/components/molecules/SocialIconLink/index.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { FunctionComponent, SVGAttributes } from 'react';

import { LogoType } from '@dnd-academy/core';
import { type LogoType } from '@dnd-academy/core';
import clsx from 'clsx';

import ExternalLink from '@/components/atoms/ExternalLink';
Expand Down Expand Up @@ -58,13 +58,13 @@ function SocialIconLink({

if (!link) {
return (
<Logo className={logoClassName} />
<Logo className={logoClassName} aria-label={type} />
);
}

return (
<ExternalLink href={link} className={className}>
<Logo className={logoClassName} />
<Logo className={logoClassName} aria-label={type} />
</ExternalLink>
);
}
Expand Down

0 comments on commit 4dda66b

Please sign in to comment.