Skip to content

Commit

Permalink
Added missing alt & replaced remaining dspace logo PNGs with SVGs
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandrevryghem committed May 15, 2024
1 parent 014944f commit 56c786d
Show file tree
Hide file tree
Showing 8 changed files with 3 additions and 27 deletions.
2 changes: 1 addition & 1 deletion cypress/e2e/submission.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ describe('New Submission page', () => {

// Upload our DSpace logo via drag & drop onto submission form
// cy.get('div#section_upload')
cy.get('div.ds-document-drop-zone').selectFile('src/assets/images/dspace-logo.png', {
cy.get('div.ds-document-drop-zone').selectFile('src/assets/images/dspace-logo.svg', {
action: 'drag-drop',
});

Expand Down
2 changes: 1 addition & 1 deletion src/app/login-page/login-page.component.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="container w-100 h-100">
<div class="text-center mt-5 row justify-content-center">
<div>
<img class="mb-4 login-logo" src="assets/images/dspace-logo.png" alt="{{'repository.image.logo' | translate}}">
<img class="mb-4 login-logo" src="assets/images/dspace-logo.svg" [alt]="'repository.image.logo' | translate">
<h1 class="h3 mb-0 font-weight-normal">{{"login.form.header" | translate}}</h1>
<ds-log-in
[isStandalonePage]="true"></ds-log-in>
Expand Down
2 changes: 1 addition & 1 deletion src/app/logout-page/logout-page.component.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="container w-100 h-100">
<div class="text-center mt-5 row justify-content-md-center">
<div class="mx-auto">
<img class="mb-4 login-logo" src="assets/images/dspace-logo.png">
<img class="mb-4 login-logo" src="assets/images/dspace-logo.svg" [alt]="'repository.image.logo' | translate">
<h1 class="h3 mb-0 font-weight-normal">{{"logout.form.header" | translate}}</h1>
<ds-log-out></ds-log-out>
</div>
Expand Down
Binary file removed src/assets/images/dspace-logo.png
Binary file not shown.
10 changes: 0 additions & 10 deletions src/themes/custom/app/login-page/login-page.component.html
Original file line number Diff line number Diff line change
@@ -1,10 +0,0 @@
<div class="container w-100 h-100">
<div class="text-center mt-5 row justify-content-center">
<div>
<img class="mb-4 login-logo" src="assets/images/dspace-logo.png">
<h1 class="h3 mb-0 font-weight-normal">{{"login.form.header" | translate}}</h1>
<ds-log-in
[isStandalonePage]="true"></ds-log-in>
</div>
</div>
</div>
4 changes: 0 additions & 4 deletions src/themes/custom/app/login-page/login-page.component.scss
Original file line number Diff line number Diff line change
@@ -1,4 +0,0 @@
.login-logo {
height: var(--ds-login-logo-height);
width: var(--ds-login-logo-width);
}
9 changes: 0 additions & 9 deletions src/themes/custom/app/logout-page/logout-page.component.html
Original file line number Diff line number Diff line change
@@ -1,9 +0,0 @@
<div class="container w-100 h-100">
<div class="text-center mt-5 row justify-content-md-center">
<div class="mx-auto">
<img class="mb-4 login-logo" src="assets/images/dspace-logo.png">
<h1 class="h3 mb-0 font-weight-normal">{{"logout.form.header" | translate}}</h1>
<ds-log-out></ds-log-out>
</div>
</div>
</div>
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
@import '../login-page/login-page.component.scss';

0 comments on commit 56c786d

Please sign in to comment.