Created separate ePerson pages for create/edit

[alexandrevryghem]

References

• Fixes eperson/epeople administration: edit view does not change browser URL #2302
• Fixes remove buttons "Delete EPerson" and "Reset Password" in "Create EPerson" form #2289
• Maintenance PR [Port main] Created separate ePerson pages for create/edit #2551

Description

This PR fixes the eperson/epeople administration tab not having a separate url for the create & edit pages. I also fixed other minor bugs related to these pages.

Instructions for Reviewers

List of changes in this PR:

• Added extra routes to AccessControlRoutingModule for the create & edit pages
• Removed all the logic to render the EPersonFormComponent on EPeopleRegistryComponent and replaced buttons to redirect to the correct new routes
• Changed the url to create a new group to make the create page urls a little bit more uniform over the whole application, like the url for the community create page for example: {dspaceObjectType}/create
• The EPersonDataService.startEditingNewEPerson method returned the wrong url, it returned the EPeople overview page instead of the edit EPerson tab
• The delete button on the EPersonFormComponent & EPeopleRegistryComponent & GroupFormComponent should be hidden when the user doesn't have enough permissions to delete it instead of just disabling it (this is how the other buttons in the application behave)
• Fixed small css issue with the spaces between the EPersonFormComponent buttons

Guidance for how to test/review this PR:

• Navigate between the tabs and check that they use separate urls and that you aren't redirected to the EPeople overview page on refresh
• Test that creating/editing/deleting an EPerson redirects you to the EPeople overview page when they succeed
• Test that the delete buttons are now hidden when the user doesn't have the right to delete them, or on the create form or when the group is a permanent group in both the EPeople/Group overview as on the create/edit forms
• Test that creating/editing/deleting a Group still behaves like before

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[github-actions]

Hi @alexandrevryghem,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[atarix83]

thanks @alexandrevryghem for this PR

overall it's working fine, i've just added a tiny minor inline comment and a small improvement to ask.
In order to uniform the eperson/group edit page route to the other dspace object edit page routes, i'd suggest to add /edit at the end of the route.
I mean instead of having

http://localhost:4000/access-control/epeople/a7a17d82-c812-494d-a1a7-43ef88f49eb9

we should have

http://localhost:4000/access-control/epeople/a7a17d82-c812-494d-a1a7-43ef88f49eb9/edit

[atarix83]

LGTM thanks @alexandrevryghem

[tdonohue]

👍 Thanks @alexandrevryghem ! Tested this as well and it works to fix both the linked issues. No new issues found. Code looks good as well.

[tdonohue]

Ported to main in #2551