Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-7_x] Fixes Incorrect operation of the keyword selection field with < and , on the Submission page #3108

Open
wants to merge 3 commits into
base: dspace-7_x
Choose a base branch
from

Conversation

VictorHugoDuranS
Copy link
Contributor

@VictorHugoDuranS VictorHugoDuranS commented Jun 8, 2024

Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:

References

Description

I changed the current validation for tag component in on keyup function for validate the keys "ENTER", "," and ";" for add the tags to Chips template.

Instructions for Reviewers

I added validation for the keys "," and ";" add the labels to the chip template because the current functionality splits the value using the keys mentioned above so I think it is the correct way to validate as it causes an error if we don't validate by those keys incorrectly separating those values, i attach an example:

Grabacion.de.pantalla.2024-06-07.a.la.s.6.43.42.p.m.mov

With validation I simplified the separation of values.

List of changes in this PR:

  • Change the validation considering the keys "," and ";" using the properties keyCode and key of the keyup event

To review and check:
Create a new item or edit item
Enter a keyword with the symbol , or <

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue
Copy link
Member

@VictorHugoDuranS : This is currently failing unit tests (specs). I'd also appreciate it if you could start to create PRs against the main branch. We've started to find that it is much easier to backport PRs from main to dspace-7_x because main has more strict lint rules. For the same reason, it has become more difficult to forward-port from dspace-7_x to main....so, I'd recommend creating PRs against main instead of dspace-7_x.

@tdonohue tdonohue changed the title Dspace 7 2679 Fixes Incorrect operation of the keyword selection field with < and , on the Submission page Jun 10, 2024
@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge port to main This PR needs to be ported to `main` branch for the next major release labels Jun 10, 2024
@tdonohue tdonohue added this to the 8.0 milestone Jun 10, 2024
@tdonohue tdonohue removed this from the 8.0 milestone Jun 24, 2024
@VictorHugoDuranS VictorHugoDuranS changed the base branch from dspace-7_x to dspace-8_x August 10, 2024 01:23
@VictorHugoDuranS VictorHugoDuranS changed the base branch from dspace-8_x to dspace-7_x August 10, 2024 01:26
@tdonohue tdonohue added component: submission and removed port to main This PR needs to be ported to `main` branch for the next major release labels Aug 21, 2024
@tdonohue tdonohue changed the title Fixes Incorrect operation of the keyword selection field with < and , on the Submission page [Port dspace-7_x] Fixes Incorrect operation of the keyword selection field with < and , on the Submission page Aug 21, 2024
@tdonohue tdonohue requested a review from atarix83 August 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: submission
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

2 participants