Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3655 - Fixes Spacing Issue Between Email Label and Email Address on Profile Setup Form #3656

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Simone-Ramundi
Copy link
Contributor

References

Description

This PR resolves an issue where the email address displayed on the profile setup form after a new user registration lacked proper spacing between the email label ("Email Address") and the actual email address. The absence of spacing caused readability issues and hindered the clarity of the label in relation to the email value.

Instructions for Reviewers

The changes in this PR ensure that the email label and the email address are clearly spaced, improving readability.

List of changes in this PR:

  • Added appropriate margin spacing to the email label to create visual separation between the label and the email address.
  • Ensured that the email label is correctly aligned with the email address to enhance the layout and user experience.

Testing Instructions:

  1. Register as a new user and submit the form to receive a validation email.
  2. Open the validation email and click the link to complete profile setup.
  3. On the profile setup form, verify that the email label ("Email Address") is correctly spaced from the email address, ensuring the text is clearly readable.

This fix ensures the email label and address are properly spaced for improved visual clarity.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge bug port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Nov 15, 2024
@tdonohue tdonohue added this to the 9.0 milestone Nov 15, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Simone-Ramundi ! This fixes the small bug. Merging immediately.

@tdonohue tdonohue merged commit bfefc41 into DSpace:main Nov 15, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

@dspace-bot
Copy link
Contributor

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Lack of Spacing Between Email Address Label and Value in Profile Setup Form
3 participants