[Port dspace-7_x] Reduce browse definition requests on simple item page (#3701) #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
bug
high priority
performance / caching
* 121561 Reduce the number of browse definition requests on Item pages by reusing the navbar request for all browse indexes * Fix test issues. --------- Co-authored-by: Koen Pauwels <[email protected]>
tdonohue
force-pushed
the
port_3701_to_7x
branch
from
df58c8a to
76539dd
Compare
|
Thanks @KoenP and @tdonohue. I tested this on a DSpace 7.6.2 instance. The number of requests made for browses is reduced. Furthermore, I noticed that the previous behavior requests browses for many fields on the page which didn't have browses defined. This was useless and wasteful. Happy to have the requests for browse definitions consolidated and read from the cache. |
alanorth
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual port of #3701 by @KoenP to
dspace-7_x