feat(trino): column name judge #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyFBB
force-pushed
the
feat/columnNameJudge
branch
from
a52d90c to
3c7382b
Compare
LuckyFBB
force-pushed
the
feat/columnNameJudge
branch
from
b4ec7f1 to
4d9ce06
Compare
LuckyFBB
force-pushed
the
feat/columnNameJudge
branch
from
fe40b30 to
4fe18ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
和 #354 一样，嵌套 columnName 在 expression 里面
但是有些地方使用了 expression 并不需要我们提示字段，因此我们需要判断当前 columnName 的路径是否在 groupBy 中
我们通过
core.collectCandidates拿到的candidates就包含了当前的路径，在ruleList里面