Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kyjung add bartype #192

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Kyjung add bartype #192

wants to merge 6 commits into from

Conversation

kyjung123
Copy link
Member

Add RecoHitBarType on TMS_ReadoutTreeWriter.cpp and TMS_TreeWriter.cpp.

@jdkio
Copy link
Contributor

jdkio commented Jan 20, 2025

Some of these are type float instead of type int. You want them all to be ints, right?

RecoHitBarType[nHits]/F

@kyjung123
Copy link
Member Author

Oh yes all of them are ints

@kyjung123 kyjung123 requested a review from jdkio January 21, 2025 18:06
jdkio
jdkio approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@jdkio jdkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went and changed the floats to ints myself. If you're happy with the changes, then merge it

LiamOS
LiamOS approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@LiamOS LiamOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, useful info to have in the output!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdkio jdkio jdkio approved these changes

@LiamOS LiamOS LiamOS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyjung123 @jdkio @LiamOS