Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

리더보드 페이지 반응형 디자인 #180

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

sounmind
Copy link
Member

@sounmind sounmind commented Jan 4, 2025

Preview

image
image
image

체크리스트

Close #119

  • 이슈가 연결되어 있나요?
  • 배포 후 브라우저 콘솔에 경고나 오류가 있나요?

@sounmind sounmind force-pushed the 119-leaderboard-responsive branch from c761c62 to 2b39664 Compare January 4, 2025 23:44
@sounmind sounmind marked this pull request as ready for review January 4, 2025 23:47
@sounmind sounmind requested a review from a team as a code owner January 4, 2025 23:47
@sounmind sounmind changed the title 짧은 브랜치 이름 리더보드 반응형 디자인 Jan 4, 2025
@sounmind sounmind changed the title 리더보드 반응형 디자인 리더보드 페이지 반응형 디자인 Jan 4, 2025
@sounmind sounmind linked an issue Jan 4, 2025 that may be closed by this pull request
@yolophg
Copy link

yolophg commented Jan 9, 2025

@sounmind 지난주 미팅 당일에 확인했는데 답변드리는 걸 깜박했네요!😅 크로매틱 view changes에서 답변드릴려고 했는데, 다른 빌드로 자꾸 이동시키면서 comment가 disable이 되어서 여기로 답변 드립니다!

작업해주신 모바일 반응형 포함하여 태블릿 반응형 모두, approve 드립니다! 감사합니다.

@sounmind
Copy link
Member Author

@sounmind 지난주 미팅 당일에 확인했는데 답변드리는 걸 깜박했네요!😅 크로매틱 view changes에서 답변드릴려고 했는데, 다른 빌드로 자꾸 이동시키면서 comment가 disable이 되어서 여기로 답변 드립니다!

작업해주신 모바일 반응형 포함하여 태블릿 반응형 모두, approve 드립니다! 감사합니다.

감사합니다☺️ 이제 PR만 승인되면 되겠네요..!

Copy link
Contributor

@Sunjae95 Sunjae95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 리뷰하고 approve를 누를까 고민했었는데 @yolophg 확인감사드립니다!
@sounmind 고생하셨습니다!

@sounmind sounmind merged commit 25cb191 into main Jan 11, 2025
11 of 12 checks passed
@sounmind sounmind deleted the 119-leaderboard-responsive branch January 11, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive Implmentation for LeaderBoard
3 participants