Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[pre-commit.ci] pre-commit autoupdate #79

wants to merge 2 commits into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 12, 2024 •
edited
Loading

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 8318c45 to 760ed89 Compare March 25, 2024 17:23
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 742d820 to c950140 Compare April 15, 2024 17:27
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from c950140 to f37e5a3 Compare April 29, 2024 17:29
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from f37e5a3 to 51eac6a Compare May 20, 2024 17:16
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 51eac6a to 7f58745 Compare June 10, 2024 17:25
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from b1d08d6 to 3651e61 Compare July 8, 2024 17:18
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 3651e61 to 8aa5d8d Compare July 22, 2024 17:26
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 8aa5d8d to 90f77c5 Compare July 29, 2024 17:29
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 2067422 to 22ec0ae Compare August 12, 2024 17:23
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 22ec0ae to bddf15e Compare August 19, 2024 17:24
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from c259b7a to afffb72 Compare September 2, 2024 17:25
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 6a4e501 to 50e94b6 Compare September 16, 2024 17:25
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 50e94b6 to 5cd9dcb Compare September 23, 2024 17:25
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 5cd9dcb to 535863a Compare September 30, 2024 17:28
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 535863a to 786fc60 Compare October 7, 2024 17:53
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 786fc60 to 6534ece Compare October 21, 2024 17:29
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 7ba3e70 to df020cf Compare November 4, 2024 17:34
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from df020cf to 7c80718 Compare November 11, 2024 17:26
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 79e4c9a to 7dc5a30 Compare November 25, 2024 17:25
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 5bfa01e to afe4b84 Compare December 9, 2024 17:27
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from fa834c5 to d63553b Compare December 16, 2024 17:28
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 244503f to 8d4e695 Compare December 23, 2024 17:29
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 3443a09 to a0b1fa9 Compare January 13, 2025 17:24
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 13, 2025
View reviewed changes
python/json_create_descriptive_stats.py
print(
f"{start_string} 'Daniel' comment: {c_comment_daniel}, {c_comment_daniel / c_surname:.2%}"
)
print(f"{start_string} birth dates: {c_date_of_birth}, {c_date_of_birth / c_surname:.2%}")

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (private)
Loading
as clear text.
This expression logs
sensitive data (private)
Loading
as clear text.
This expression logs
sensitive data (private)
Loading
as clear text.

Copilot Autofix AI 11 days ago

To fix the problem, we should avoid logging sensitive information directly. Instead, we can log only non-sensitive statistical summaries or anonymize the data before logging. In this case, we can remove the detailed logging of specific counts and percentages related to sensitive data and replace it with a more general summary.

  • Remove or anonymize the logging of sensitive data such as birth dates, death dates, and other personal information.
  • Update the logging statements to provide a general summary without exposing specific sensitive details.
  • Ensure that the changes do not alter the existing functionality of the code.
Suggested changeset 1
python/json_create_descriptive_stats.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/python/json_create_descriptive_stats.py b/python/json_create_descriptive_stats.py
--- a/python/json_create_descriptive_stats.py
+++ b/python/json_create_descriptive_stats.py
@@ -73,18 +73,16 @@
         print(f"For the entries of {type_string}")
-    print(f"{start_string} ISNI id: {c_isni}, {c_isni / c_surname:.2%}")
-    print(
-        f"{start_string} 'Daniel' comment: {c_comment_daniel}, {c_comment_daniel / c_surname:.2%}"
-    )
-    print(f"{start_string} birth dates: {c_date_of_birth}, {c_date_of_birth / c_surname:.2%}")
-    print(f"{start_string} death dates: {c_date_of_death}, {c_date_of_death / c_surname:.2%}")
-    print(f"{start_string} functions: {c_functions}, {c_functions / c_surname:.2%}")
-    print(f"{start_string} images: {c_images}, {c_images / c_surname:.2%}")
-    print(f"{start_string} name: {c_name}, {c_name / c_surname:.2%}")
-    print(f"{start_string} place of birth: {c_place_of_birth}, {c_place_of_birth / c_surname:.2%}")
-    print(f"{start_string} place of death: {c_place_of_death}, {c_place_of_death / c_surname:.2%}")
-    print(f"{start_string} sources: {c_sources}, {c_sources / c_surname:.2%}")
-    print(f"{start_string} sources other: {c_sources_other}, {c_sources_other / c_surname:.2%}")
-    print(f"{start_string} surname: {c_surname}, {c_surname / c_surname:.2%}")
-    print(f"{start_string} titles: {c_titles}, {c_titles / c_surname:.2%}")
-    print(f"{start_string} wikidata id: {c_wikidata}, {c_wikidata / c_surname:.2%}")
+    print(f"{start_string} ISNI id: {c_isni}")
+    print(f"{start_string} 'Daniel' comment: {c_comment_daniel}")
+    print(f"{start_string} birth dates: {c_date_of_birth}")
+    print(f"{start_string} death dates: {c_date_of_death}")
+    print(f"{start_string} functions: {c_functions}")
+    print(f"{start_string} images: {c_images}")
+    print(f"{start_string} name: {c_name}")
+    print(f"{start_string} place of birth: {c_place_of_birth}")
+    print(f"{start_string} place of death: {c_place_of_death}")
+    print(f"{start_string} sources: {c_sources}")
+    print(f"{start_string} sources other: {c_sources_other}")
+    print(f"{start_string} surname: {c_surname}")
+    print(f"{start_string} titles: {c_titles}")
+    print(f"{start_string} wikidata id: {c_wikidata}")
 
EOF
@@ -73,18 +73,16 @@
print(f"For the entries of {type_string}")
print(f"{start_string} ISNI id: {c_isni}, {c_isni / c_surname:.2%}")
print(
f"{start_string} 'Daniel' comment: {c_comment_daniel}, {c_comment_daniel / c_surname:.2%}"
)
print(f"{start_string} birth dates: {c_date_of_birth}, {c_date_of_birth / c_surname:.2%}")
print(f"{start_string} death dates: {c_date_of_death}, {c_date_of_death / c_surname:.2%}")
print(f"{start_string} functions: {c_functions}, {c_functions / c_surname:.2%}")
print(f"{start_string} images: {c_images}, {c_images / c_surname:.2%}")
print(f"{start_string} name: {c_name}, {c_name / c_surname:.2%}")
print(f"{start_string} place of birth: {c_place_of_birth}, {c_place_of_birth / c_surname:.2%}")
print(f"{start_string} place of death: {c_place_of_death}, {c_place_of_death / c_surname:.2%}")
print(f"{start_string} sources: {c_sources}, {c_sources / c_surname:.2%}")
print(f"{start_string} sources other: {c_sources_other}, {c_sources_other / c_surname:.2%}")
print(f"{start_string} surname: {c_surname}, {c_surname / c_surname:.2%}")
print(f"{start_string} titles: {c_titles}, {c_titles / c_surname:.2%}")
print(f"{start_string} wikidata id: {c_wikidata}, {c_wikidata / c_surname:.2%}")
print(f"{start_string} ISNI id: {c_isni}")
print(f"{start_string} 'Daniel' comment: {c_comment_daniel}")
print(f"{start_string} birth dates: {c_date_of_birth}")
print(f"{start_string} death dates: {c_date_of_death}")
print(f"{start_string} functions: {c_functions}")
print(f"{start_string} images: {c_images}")
print(f"{start_string} name: {c_name}")
print(f"{start_string} place of birth: {c_place_of_birth}")
print(f"{start_string} place of death: {c_place_of_death}")
print(f"{start_string} sources: {c_sources}")
print(f"{start_string} sources other: {c_sources_other}")
print(f"{start_string} surname: {c_surname}")
print(f"{start_string} titles: {c_titles}")
print(f"{start_string} wikidata id: {c_wikidata}")

Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
ee8b335 
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.5.0...v5.0.0)
- [github.com/astral-sh/ruff-pre-commit: v0.5.2 → v0.9.2](astral-sh/ruff-pre-commit@v0.5.2...v0.9.2)
- [github.com/pre-commit/mirrors-mypy: v1.8.0 → v1.14.1](pre-commit/mirrors-mypy@v1.8.0...v1.14.1)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 7f63a75 to ee8b335 Compare January 20, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants