Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4561.
deleteEventMessageDataAfterEventStarted
set totrue
by default. If this flag is enabled, theEventController
will delete themessageData
and theparsedMessageData
of events after they have been started. This is to save memory in case events have a long duration and need to be persisted in the EventController for a while to not be retriggered.deleteEventMessageDataAfterEventStarted
. Only if an event is dispatched for the second time (e.g. when the user seeks back) the message data will not be included in the dispatched event. In this case, the app would need to persist themessageData
if required.I am open for feedback on this one. As an alternative, we could also define an
eventMessagePersistDuration
after which we delete the payload.In any case, we need to find a solution for events that have a long duration, as outlined in #4561.