Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1042 - Improve user experience on Failed Snapshot Delete #1390

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

snf2ye
Copy link
Contributor

@snf2ye snf2ye commented Dec 13, 2022

Changes included in PR:

  1. Switch to default successful undo instead of throwing fatal error exception on UNDO
    Why?
  • We still don't want to 'UNDO' delete operations - By just passing through the undo steps, we don't actually try to undo any delete operations. "UNDO" would actually mean recreating resources and that is way too messy.
  • Allow unlock undo steps to run - By passing through the undo steps, we eventually hit the "undo" steps for the snapshot and dataset lock steps. This unlocks the snapshot and dataset so they don't "disappear" in the user's view.
  1. Reorder SAM resource delete step
    If we want to re-run the delete flight, we need the SAM resource to still exist. So, we should do this step last so that we can ensure all of the rest of the delete steps passed before removing it.

  2. Add note about snapshot delete in open api spec
    I believe the main goal of the confusing error messages previously returned is to alert the user that UNDOing the delete didn't work. I think we can directly communicate this via the endpoint description.

@snf2ye snf2ye changed the title Improve user experience on Failed Snapshot Delete [Proposal] Improve user experience on Failed Snapshot Delete Dec 13, 2022
@snf2ye snf2ye changed the title [Proposal] Improve user experience on Failed Snapshot Delete DT-1042 - Improve user experience on Failed Snapshot Delete Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant