Skip to content

Commit

Permalink
clarify comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mspector committed Oct 25, 2023
1 parent 77dab58 commit 07b7410
Showing 1 changed file with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,11 @@ public void streamInputFromBlobStorage(

private BlobContainerClient constructBlockBlobClient(
String workspaceId, String blobstorageDetails) {
// get workspace blob storage endpoint and token
// (the line below was copied directly from WDS)
// var blobstorageDetails = workspaceManagerDao.getBlobStorageUrl(workspaceId, authToken);

// the url we get from WSM already contains the token in it, so no need to specify sasToken
// separately
// TODO: determine where blobstorageDetails should come from.
// This implementation is 95% copied from WDS's, in which they call WSM's APIs to retrieve a url
// with an included SAS token.
// The implementation here assumes that this url+token will be passed in by WSM itself when it
// ultimately calls the pgDump function.

BlobServiceClient blobServiceClient =
new BlobServiceClientBuilder().endpoint(blobstorageDetails).buildClient();
Expand Down

0 comments on commit 07b7410

Please sign in to comment.