Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOAZ-371] Misc fixes for running wsm on azure. #1794

Merged
merged 36 commits into from
Oct 22, 2024
Merged

[TOAZ-371] Misc fixes for running wsm on azure. #1794

merged 36 commits into from
Oct 22, 2024

Conversation

jsaun
Copy link
Contributor

@jsaun jsaun commented Oct 8, 2024

Misc work to get WSM running on Azure.

  1. Make the service identity auth token scopes configurable at runtime on Azure.
  2. Allow calling azure specific methods from CrlService when useCrl is false.
  3. Allow setting wsmSaEmail in config on Azure since GoogleCredentials are not available.
  4. Added logging in a few spots to troubleshoot.

jsaun and others added 30 commits April 15, 2024 22:56
@jsaun
Set MI auth token scope from env var
6e30810
@jsaun
Change google credentials profile to default
71046ac
@jsaun
Add logging
ee7aa93
@jsaun
Fix imports
a610b93
@jsaun
Merge branch 'main' into jsaun/azure-scope
2b0cb6b
@jsaun
spotlessApply
40f7741
@jsaun
Merge branch 'jsaun/azure-scope' of https://github.com/DataBiosphere/…
96e7a73 
…terra-workspace-manager into jsaun/azure-scope
@jsaun
Use wsm managed identity service account
30351df
@jsaun
Update
ca56421
@jsaun
Fix null clientConfig if crl is off
0fbec90
@jsaun
Fix
0b8d242
@jsaun
Add test logging
3e708b7
@jsaun
Logging
096a59a
@jsaun
Add try/catch
2b0ad86
@jsaun
Logging
35fc541
@jsaun
Fix
c3a8f74
@jsaun
Remove CRL asserts
9d68e85
@jsaun
Testing
3fa9c99
@dvoet
fix isApplicationEnabledInSam
ce55d9e
@jsaun
Merge remote-tracking branch 'origin/wor-1722' into jsaun/azure-scope
368e825
@jsaun
Merge branch 'main' into jsaun/azure-scope
be0fac3
@jsaun
Fix merge
64fa6f5
@jsaun
Add logging
687e306
@jsaun
More logging
b28c435
@jsaun
Bump LZ version
76f5a69
@jsaun
Update CrlService.java
e42a5f6
@jsaun
Update GcpUtils.java
7b1ba01
@jsaun
clean up
aced279
@jsaun
Update ControlledAzureResourceApiController.java
edd3f65
@jsaun
change profile order, whitespace
4ceddba
@jsaun jsaun changed the title WSM on Azure Misc fixes for running wsm on azure. Oct 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
41.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jsaun jsaun changed the title Misc fixes for running wsm on azure. [TOAZ-371] Misc fixes for running wsm on azure. Oct 9, 2024
@jsaun jsaun requested a review from giventocode October 10, 2024 16:38
@jsaun jsaun marked this pull request as ready for review October 10, 2024 20:12
@jsaun jsaun requested review from a team, marctalbott and kevinmarete and removed request for a team October 10, 2024 20:12
@jsaun jsaun merged commit 8f8354f into main Oct 22, 2024
19 checks passed
@jsaun jsaun deleted the jsaun/azure-scope branch October 22, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinmarete kevinmarete kevinmarete approved these changes

@marctalbott marctalbott marctalbott approved these changes

@giventocode giventocode giventocode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsaun @giventocode @marctalbott @kevinmarete @dvoet