-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracer): deprecates patch_all #11918
base: main
Are you sure you want to change the base?
Conversation
|
12513d0
to
fb33c53
Compare
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 27.04s Total duration (35m 26.71s time saved) |
BenchmarksBenchmark execution time: 2025-01-17 20:12:14 Comparing candidate commit 3e580da in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
@@ -56,7 +56,7 @@ | |||
|
|||
__all__ = [ | |||
"patch", | |||
"patch_all", | |||
"_patch_all", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. Customers that once were able to
from ddtrace import patch_all
patch_all()
will now get an import error. Or am I missing something? Will this proposed change happen in a major version bump?
Checklist
Reviewer Checklist