Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracer): deprecates patch_all #11918

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

ZStriker19
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 13, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/deprecate_patch_all-244eddcfacb1da14.yaml            @DataDog/apm-python
benchmarks/ddtrace_run/scenario.py                                      @DataDog/apm-core-python
ddtrace/__init__.py                                                     @DataDog/apm-core-python
ddtrace/_monkey.py                                                      @DataDog/apm-core-python
ddtrace/bootstrap/preload.py                                            @DataDog/apm-core-python
ddtrace/contrib/aws_lambda/__init__.py                                  @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/httplib/__init__.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/pytest/plugin.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/kombu/__init__.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/sanic/__init__.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/snowflake/__init__.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/urllib3/__init__.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
docs/api.rst                                                            @DataDog/python-guild
tests/appsec/iast/fixtures/entrypoint/views.py                          @DataDog/asm-python
tests/commands/test_runner.py                                           @DataDog/apm-core-python
tests/contrib/algoliasearch/test.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/django/test_django.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg/test_psycopg_snapshot.py                          @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg2/test_psycopg.py                                  @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg2/test_psycopg_snapshot.py                         @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/starlette/test_starlette.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
tests/tracer/test_monkey.py                                             @DataDog/apm-sdk-api-python

@ZStriker19 ZStriker19 force-pushed the zachg/deprecate_patch_all branch from 12513d0 to fb33c53 Compare January 13, 2025 18:43
@ZStriker19 ZStriker19 changed the title chore(tracer): deprecate patch_all chore(tracer): deprecates patch_all Jan 13, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 13, 2025

Datadog Report

Branch report: zachg/deprecate_patch_all
Commit report: 3e580da
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 27.04s Total duration (35m 26.71s time saved)

@ZStriker19 ZStriker19 changed the title chore(tracer): deprecates patch_all chore(tracer): deprecates patch_all [3.0] Jan 13, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2025

Benchmarks

Benchmark execution time: 2025-01-17 20:12:14

Comparing candidate commit 3e580da in PR branch zachg/deprecate_patch_all with baseline commit ef4c997 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@ZStriker19 ZStriker19 changed the title chore(tracer): deprecates patch_all [3.0] chore(tracer): deprecates patch_all Jan 16, 2025
@@ -56,7 +56,7 @@

__all__ = [
"patch",
"patch_all",
"_patch_all",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. Customers that once were able to

from ddtrace import patch_all
patch_all()

will now get an import error. Or am I missing something? Will this proposed change happen in a major version bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants