Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(iast): enable iast_aggregated_leak_testing tests #12005

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Jan 20, 2025

Enable iast_aggregated_leak_testing

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 20, 2025

CODEOWNERS have been resolved as:

hatch.toml                                                              @DataDog/python-guild
tests/appsec/suitespec.yml                                              @DataDog/asm-python

@avara1986 avara1986 added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 20, 2025
@avara1986 avara1986 changed the title chore: enable iast_aggregated_leak_testing tests ci(iast): enable iast_aggregated_leak_testing tests Jan 20, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 20, 2025

Datadog Report

Branch report: avara1986/enable_iast_aggregated_leak_testing
Commit report: 6293f03
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 17.18s Total duration (35m 9.41s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2025

Benchmarks

Benchmark execution time: 2025-01-20 15:23:10

Comparing candidate commit 6293f03 in PR branch avara1986/enable_iast_aggregated_leak_testing with baseline commit 0111544 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@avara1986 avara1986 marked this pull request as ready for review January 20, 2025 15:25
@avara1986 avara1986 requested review from a team as code owners January 20, 2025 15:25
@avara1986 avara1986 requested a review from tabgok January 20, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant