Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule for "silent execution" of popen based on Pytorch attack. Some cleanup of processing whl files #119

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

christophetd
Copy link
Contributor

@christophetd christophetd commented Jan 3, 2023

Replaces #116

Co-authored-by: Zachary Allen <[email protected]>
@christophetd christophetd changed the base branch from main to v1.0-rc January 3, 2023 15:59
@christophetd christophetd requested a review from zmallen January 3, 2023 20:49
return self.analyzer.analyze_sourcecode(tmpdirname, rules=rules)
elif os.path.isdir(path):
return self.analyzer.analyze_sourcecode(path, rules=rules)
else:
raise Exception(f"Path {path} is not a directory nor a tar.gz archive.")
raise Exception(f"Path {path} is not a directory nor an archive type supported by GuardDog.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll need to decouple that code from the utils one at some point, but it's "good enough" for now

@christophetd christophetd merged commit 39e9700 into v1.0-rc Jan 3, 2023
@christophetd christophetd deleted the triton_rule_silent_execution branch January 3, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants