[SINT-1547] Add NPM confusion analyzer #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re generated from same pyproject.toml and poetry.lock
enelli
reviewed
Oct 20, 2023
There was a problem hiding this comment.
Adding a short description to the NPM metadata heuristics would be a good addition. Otherwise, LGTM!
enelli
reviewed
Oct 20, 2023
| @@ -319,6 +319,7 @@ | |||
| } | |||
| ] | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
Should be fixed now
juliendoutre
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Looks good to me! We tested this new check with @jamessteel123 on the https://www.npmjs.com/package/darcyclarke-manifest-pkg NPM package, a proof of concept for this attack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an analyzer which detects NPM confusion events. Specifically it checks when the version's manifest in NPM does not match the content in the package.json in a manner that can change the behavior of the code, or mislead the consumer of the package (report bugs to the wrong place, link to incorrect documentation).