Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all .venv files and example.venv files and error_log.txt ... #50

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Remove all .venv files and example.venv files and error_log.txt ... #50

merged 1 commit into from
Aug 4, 2024

Conversation

pselvana
Copy link
Contributor

@pselvana pselvana commented Aug 3, 2024

Also remove node packages for prettier and use python. Update requirements-dev.txt.

@pselvana
Remove all .venv files and example.venv files and error_log.txt. Remo…
6d7f7cd 
…ve node packages for prettier and use python. Update requirements-dev.txt.
@pselvana pselvana requested a review from sidmohan0 August 4, 2024 00:04
sidmohan0
sidmohan0 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@sidmohan0 sidmohan0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • new venv
  • built as 3.3.1b1 locally (did not push to pypi yet)
  • pip install using the local tar.gz file
  • all tests passed

@sidmohan0 sidmohan0 merged commit 1e5f14b into dev Aug 4, 2024
3 checks passed
@pselvana pselvana deleted the ci/cleanup-build branch August 4, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidmohan0 sidmohan0 sidmohan0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pselvana @sidmohan0