Feature: Interfacing ML code with MiMA #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to reflect model now takes 3 inputs and concatenates them, rather than a pre-concatted input. Test is very basic but shows that TF davenet does the same thing as PyTorch davenet.
It was there to test something.
The models' arguments were being sent in the wrong order. It should be pressure, latitude, then wind. Also the pressure should be in Pa, so no need for scale factor of 100.
|
Closes #13 in the early @SimonClifford commits. |
|
@SimonClifford commits address TensorFlow coupling. |
|
@jatkinson1000 commits close #11 and close #12 and therefore close #4 . |
|
@jatkinson1000 closes #5, although we may revisit. |
|
Also closes #1 in earliest @jatkinson1000 commits (we could merge CMake docs are included in |
mondus
commented
May 24, 2023
There was a problem hiding this comment.
A few small suggestions.
- Move the CSD3 submissions scrips into a
scripts\csd3folder as they are hardware specific. - Remove hardcoded home directories in the submissions scripts. Replace with a variable or argument.
- pytorch README.md could do with a bit more detail on what the scripts are. This could be opened as an issue for future work though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
@jatkinson1000 - covering #4 and #5
cg_drag.f90to accommodate drag forcing from various different approachesThis way each approach will call the NN twice, once with zonal, once with meridional, but tensors will only be written to shared memory once.
@SimonClifford - covering #3
We then need to conduct benchmarking: