Update WebSockets Spec #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the necessary changes to update to the latest version of the spec. Note: As a result of the new spec,
CAN*devices are no longer aliased to their non-can counterparts. Personally, I'm fine with this, but we can think about ways to bring back this behavior if you feel that it's important. Despite this, however, I left the code supporting alternate types in$schema$.java. I don't see any harm to keeping it around, and it could be useful if we ever want to do something similar in the future.At the moment,
build.gradlepoints to a PR'd version of the spec. This PR should not be merged until wpilibsuite/allwpilib#6679 is merged andbuild.gradleis updated to point at the WPILib commit.