-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composer meta analyzer: add DEBUG logging #4546
composer meta analyzer: add DEBUG logging #4546
Conversation
e40789b
to
c089080
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
As this was a relatively new / last minute feature some extra logging can be helpful. In my test instance with real world data I am not seeing the log lines I was expecting, so I am not if it's correctly using the V2 API now. |
Some of the new log statements do not provide any context (i.e. repository, package URL). Two options:
The latter would also greatly help with driving #3234 forward. |
Hmm was expecting this, but hoped you would forget :-) In practice I usually just add the Thread-Id to the log pattern and filter on that. But yeah, more context is helpful. I don't have time to do the MDC now, maybe in the other Composer related draft PR later on. |
Signed-off-by: Valentijn Scholten <[email protected]>
Signed-off-by: Valentijn Scholten <[email protected]>
Signed-off-by: Valentijn Scholten <[email protected]>
c9146a2
to
e74ea99
Compare
Add some DEBUG log lines to help debugging (possible/future) problems.