-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting Java to Kotlin #196
Open
psteiger
wants to merge
3
commits into
dev
Choose a base branch
from
issue-147-2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
84 changes: 0 additions & 84 deletions
84
app/src/main/java/br/org/cesar/discordtime/stickysessions/app/StickySessionApplication.java
This file was deleted.
Oops, something went wrong.
83 changes: 83 additions & 0 deletions
83
app/src/main/java/br/org/cesar/discordtime/stickysessions/app/StickySessionApplication.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package br.org.cesar.discordtime.stickysessions.app | ||
|
|
||
| import android.app.Application | ||
|
|
||
| import com.crashlytics.android.Crashlytics | ||
|
|
||
| import br.org.cesar.discordtime.stickysessions.injectors.components.DaggerListSessionComponent | ||
| import br.org.cesar.discordtime.stickysessions.injectors.components.DaggerLobbyComponent | ||
| import br.org.cesar.discordtime.stickysessions.injectors.components.DaggerLoginComponent | ||
| import br.org.cesar.discordtime.stickysessions.injectors.components.DaggerMeetingComponent | ||
| import br.org.cesar.discordtime.stickysessions.injectors.components.DaggerSessionComponent | ||
| import br.org.cesar.discordtime.stickysessions.injectors.modules.ContextModule | ||
| import br.org.cesar.discordtime.stickysessions.ui.list.ListSessionsActivity | ||
| import br.org.cesar.discordtime.stickysessions.ui.lobby.LobbyActivity | ||
| import br.org.cesar.discordtime.stickysessions.ui.login.LoginActivity | ||
| import br.org.cesar.discordtime.stickysessions.ui.meeting.MeetingActivity | ||
| import br.org.cesar.discordtime.stickysessions.ui.session.SessionActivity | ||
| import io.fabric.sdk.android.Fabric | ||
|
|
||
| open class StickySessionApplication : Application() { | ||
|
|
||
| protected var mLoginComponentBuilder: DaggerLoginComponent.Builder | ||
| protected var mLobbyComponentBuilder: DaggerLobbyComponent.Builder | ||
| protected var mSessionComponentBuilder: DaggerSessionComponent.Builder | ||
| protected var mSessionListBuilder: DaggerListSessionComponent.Builder | ||
| protected var mMeetingComponentBuilder: DaggerMeetingComponent.Builder | ||
|
|
||
| override fun onCreate() { | ||
| super.onCreate() | ||
| configureLoginInjectorBuilder() | ||
| configureMainInjectorBuilder() | ||
| configureSessionInjectorBuilder() | ||
| configureSessionListInjectorBuilder() | ||
| configureMeetingInjectorBuilder() | ||
|
|
||
| Fabric.with(this, Crashlytics()) | ||
| } | ||
|
|
||
| protected fun configureLoginInjectorBuilder() { | ||
| mLoginComponentBuilder = DaggerLoginComponent.builder() | ||
| } | ||
|
|
||
| protected open fun configureMainInjectorBuilder() { | ||
| mLobbyComponentBuilder = DaggerLobbyComponent.builder() | ||
| .contextModule(ContextModule(applicationContext)) | ||
| } | ||
|
|
||
| protected open fun configureSessionInjectorBuilder() { | ||
| mSessionComponentBuilder = DaggerSessionComponent.builder() | ||
| .contextModule(ContextModule(applicationContext)) | ||
| } | ||
|
|
||
| protected open fun configureSessionListInjectorBuilder() { | ||
| mSessionListBuilder = DaggerListSessionComponent.builder() | ||
| .contextModule(ContextModule(applicationContext)) | ||
| } | ||
|
|
||
| protected fun configureMeetingInjectorBuilder() { | ||
| mMeetingComponentBuilder = DaggerMeetingComponent.builder() | ||
| .contextModule(ContextModule(applicationContext)) | ||
| } | ||
|
|
||
| fun inject(activity: LoginActivity) { | ||
| mLoginComponentBuilder.build().inject(activity) | ||
| } | ||
|
|
||
| fun inject(activity: LobbyActivity) { | ||
| mLobbyComponentBuilder.build().inject(activity) | ||
| } | ||
|
|
||
| fun inject(activity: SessionActivity) { | ||
| mSessionComponentBuilder.build().inject(activity) | ||
| } | ||
|
|
||
| fun inject(activity: ListSessionsActivity) { | ||
| mSessionListBuilder.build().inject(activity) | ||
| } | ||
|
|
||
| fun inject(activity: MeetingActivity) { | ||
| mMeetingComponentBuilder.build().inject(activity) | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think better to use Lazy initialization in each build? each build is just instanced in the first use instead of loading all.
e.g:
protected var mLoginComponentBuilder: DaggerLoginComponent.Builder by lazy {
DaggerLoginComponent.builder()
}