Update module for Pimcore 10.x #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkul0
reviewed
Apr 24, 2023
Comment on lines
77
to
+78
| if ($handler) { | ||
| foreach ($languages as $language) { | ||
| $progress = $progress->add($handler->getEnrichmentProgress( | ||
| $child, | ||
| $this->getLocalizedKeyValue($data, $relation, $language) | ||
| )); | ||
| if ($field->isLocalized()) { |
There was a problem hiding this comment.
if ($handler && $field->isLocalized()) {
punk-raider
suggested changes
Apr 24, 2023
| class EnrichmentController extends AdminController | ||
| { | ||
| /** | ||
| * @var EnrichmentService | ||
| * @var EnrichmentProgressService | ||
| */ | ||
| private $service; |
There was a problem hiding this comment.
Missing property type.
After adding property type comment above will be redundant.
You changed required PHP version to 8.1 so please add missing return types, parameters and properties types.
Please review also other files in repository and add missing elements.
Please remove also redundant comments.
| $child, | ||
| $this->getLocalizedKeyValue($data, $relation, $language) | ||
| )); | ||
| if ($field->isLocalized()) { |
There was a problem hiding this comment.
If field is not localized progress won't be calculated for the field at all, is it intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.