-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: warn about default variables set by conda #5466
Conversation
In the documentation: could you add the command line that a user should type in order to clear the variable? |
I added the note you requested and I think this is ready to merge. |
I see this in the conda CXXFLAGS: $ echo $CXXFLAGS
-fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/axel/micromamba/envs/warpx-cpu-mpich-dev/include I never realized they set |
I guess I'll add Has anyone done a performance test for the default flags vs unsetting them yet? @EZoni |
Co-authored-by: Axel Huebl <[email protected]>
I did not know either, I discovered this by chance while looking into some other flags. I'm curious to know how to do this, thanks for looking into it.
I have not done any specific tests on my end. |
Thanks for the update. Yes, tests would be interesting because there are in fact not a ton that |
This is not a problem. We append Example: $ cmake --build build --verbose
...
cd /home/axel/src/warpx/build/_deps/fetchedopenpmd-build && /home/axel/micromamba/envs/warpx-cpu-mpich-dev/bin/ccache /home/axel/micromamba/envs/warpx-cpu-mpich-dev/bin/x86_64-conda-linux-gnu-c++ -DADIOS2_USE_MPI -DNDEBUG -D_FORTIFY_SOURCE=2 -DopenPMD_USE_VERIFY=1 -I/home/axel/src/warpx/build/_deps/fetchedopenpmd-src/include -I/home/axel/src/warpx/build/_deps/fetchedopenpmd-build/include -isystem /home/axel/src/warpx/build/_deps/fetchedopenpmd-src/share/openPMD/thirdParty/json/single_include -isystem /home/axel/src/warpx/build/_deps/fetchedopenpmd-src/share/openPMD/thirdParty/toml11 -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/axel/micromamba/envs/warpx-cpu-mpich-dev/include -O3 -DNDEBUG -std=c++17 -fPIC -MD -MT _deps/fetchedopenpmd-build/CMakeFiles/openPMD.dir/src/IO/ADIOS/CommonADIOS1IOHandler.cpp.o -MF CMakeFiles/openPMD.dir/src/IO/ADIOS/CommonADIOS1IOHandler.cpp.o.d -o CMakeFiles/openPMD.dir/src/IO/ADIOS/CommonADIOS1IOHandler.cpp.o -c /home/axel/src/warpx/build/_deps/fetchedopenpmd-src/src/IO/ADIOS/CommonADIOS1IOHandler.cpp |
Adding a warning about conda setting default environment variables when installing CMake, as discussed during the developer meeting.
It will be displayed at the onde of the conda section (https://warpx.readthedocs.io/en/latest/install/dependencies.html#conda-linux-macos-windows):