CI: install clang dependencies directly from LLVM #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
commented
Jan 17, 2025
Comment on lines
-15
to
-17
| # This dependency file is currently used within a docker container, | ||
| # which does not come (among others) with wget, xz-utils, curl, git, | ||
| # ccache, and pkg-config pre-installed. |
There was a problem hiding this comment.
I think what was stated in this comment is not valid since we removed the Ubuntu 23.10 container in #5474.
ax3l
reviewed
Jan 18, 2025
| export CXX=$(which clang++-17) | ||
| export CC=$(which clang-17) | ||
| # parse clang version number from command line | ||
| version_number=${1} |
There was a problem hiding this comment.
Saw too late.
You could make the script more robust by checking that the number of arguments are exactly one (or two?) (0 is the program/script name, 1 the first argument) and otherwise throw a helpful error message. In bash, the number of args is $#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was a suggestion by @WeiqunZhang in the context of debugging the clang sanitizer issue currently addressed in #5492. I'm extracting all related changes from #5492 to implement and test the LLVM installation separately here.
This effectively unifies the CI scripts to install clang dependencies into one single script that reads the clang version number from the command line.
I think all CI checks should pass here as a prerequisite for debugging the clang sanitizer issue further in #5492.