Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Mandalay and its Armour modules #96

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alex-williams
Copy link

No description provided.

@bgol
Copy link
Contributor

bgol commented Nov 1, 2024

Your shipyard.csv is wrong. The trailing comma should only be there if it does NOT have an entitlement otherwise it needs to be there (for an empty fourth column).
The Mandalay entry needs a comma because there is no entitlement.

@alex-williams
Copy link
Author

Your shipyard.csv is wrong. The trailing comma should only be there if it does NOT have an entitlement otherwise it needs to be there (for an empty fourth column). The Mandalay entry needs a comma because there is no entitlement.

indeed, fixed now, did it in a hurry, so completely forgot it was a CSV.

Copy link
Contributor

@bgol bgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be a comma after the entitelment.
So line 9,18,30,33-39 should not have a trailing comma at the end of line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants