Fix: Moved focusTrapTarget from ec-modal__content to ec-modal (#1978)

Ebury · Jun 12, 2024 · 396b453 · 396b453
1 parent 2b43831
commit 396b453
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ebury/chameleon-components",
-  "version": "2.8.8",
+  "version": "2.8.9",
   "main": "src/main.ts",
   "sideEffects": false,
   "author": "Ebury Team (http://labs.ebury.rocks/)",

diff --git a/src/components/ec-modal/ec-modal.spec.ts b/src/components/ec-modal/ec-modal.spec.ts
@@ -441,7 +441,7 @@ describe('EcModal', () => {
         attachTo: element,
       });
       const container = wrapper.vm.getFocusTrapContainer();
-      expect(container).toBe(wrapper.findByDataTest<HTMLElement>('ec-modal__content').element);
+      expect(container).toBe(wrapper.findByDataTest<HTMLElement>('ec-modal').element);
     });
   });
 

diff --git a/src/components/ec-modal/ec-modal.vue b/src/components/ec-modal/ec-modal.vue
@@ -1,6 +1,7 @@
 <template>
   <transition name="ec-modal__fade">
     <div
+      ref="focusTrapTarget"
       v-if="show"
       class="ec-modal"
       :style="zIndexStyle"
@@ -11,7 +12,6 @@
       @click.self="closeModal()"
     >
       <div
-        ref="focusTrapTarget"
         class="ec-modal__content"
         data-test="ec-modal__content"
         :class="{ 'ec-modal--lg': large }"