Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix cln-grpc example. #6771

Merged
merged 1 commit into from
Nov 14, 2023
Merged

doc: fix cln-grpc example. #6771

merged 1 commit into from
Nov 14, 2023

Conversation

tonyaldon
Copy link
Contributor

  • Add instruction to generate primitives_pb2.py file,
  • Import grpc in the Python script.

vincenzopalazzo
vincenzopalazzo approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 91660ce

@tonyaldon @cdecker
doc: fix cln-grpc example.
ed4a6e9 
- Add instruction to generate `primitives_pb2.py` file,
- Import `grpc` in the Python script.

Changelog-None
@cdecker cdecker force-pushed the doc-fix-cln-grpc-example branch from 91660ce to ed4a6e9 Compare October 28, 2023 15:49
@cdecker
Copy link
Member

cdecker commented Oct 28, 2023

Rebased on top of master

@nepet nepet added this to the v23.11 milestone Nov 13, 2023
nepet
nepet approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@nepet nepet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ed4a6e9

@nepet nepet merged commit cce4f68 into ElementsProject:master Nov 14, 2023
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

@nepet nepet nepet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v23.11
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyaldon @cdecker @nepet @vincenzopalazzo