-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix broken CI after locking versions #7975
Conversation
These workflows are failing due to `ubuntu-latest` being updated from version `22.04` to `24.04`. Reference: actions/runner-images#10636 Changelog-None.
looks good to me, I like using specific versions for things. 4cca566 ack |
Poetry will no longer include the `poetry-plugin-export` plugin by default, which is essential for exporting dependencies. So, we now need to install it explicitly.
Fix for `The Poetry configuration is invalid: - project must contain ['name'] properties`
23fee90 looks good to me ack |
Good fix @ShahanaFarooqui, thanks ^^ ACK 23fee90 |
Any particular reason why PRs that have the same changes are ignored: #7909 ? |
@fanquake The PR was not intentionally ignored. The CI broke due to updates in Poetry and the ubuntu-latest versions and I began working on a fix. While addressing the Poetry issue for macOS, I noticed that the symlink should also be removed and did that as part of the cleanup. I hope this clears up any confusion. However, I overlooked removing the symlink from the |
Fair enough. The branch in #7909 is restored. |
These workflows are failing due to the update of
ubuntu-latest
from version22.04
to24.04
. For now, we can lock the Ubuntu version to22.04
to resolve the issue and plan to update to24.04
once it becomes more stable on GitHub Actions.Reference: actions/runner-images#10636
Changelog-None.