Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix broken CI after locking versions #7975

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

ShahanaFarooqui
Copy link
Collaborator

These workflows are failing due to the update of ubuntu-latest from version 22.04 to 24.04. For now, we can lock the Ubuntu version to 22.04 to resolve the issue and plan to update to 24.04 once it becomes more stable on GitHub Actions.

Reference: actions/runner-images#10636

Changelog-None.

These workflows are failing due to `ubuntu-latest` being updated from version `22.04` to `24.04`.

Reference: actions/runner-images#10636

Changelog-None.
@evansmj
Copy link
Contributor

evansmj commented Jan 6, 2025

looks good to me, I like using specific versions for things.

4cca566 ack

Poetry will no longer include the `poetry-plugin-export` plugin by default, which is essential for exporting dependencies. So, we now need to install it explicitly.
Fix for `The Poetry configuration is invalid:  - project must contain ['name'] properties`
@ShahanaFarooqui ShahanaFarooqui changed the title ci: Lock Ubuntu version on 22.04 ci: Fix broken CI after locking versions Jan 7, 2025
@evansmj
Copy link
Contributor

evansmj commented Jan 8, 2025

23fee90 looks good to me ack

@cdecker
Copy link
Member

cdecker commented Jan 9, 2025

Good fix @ShahanaFarooqui, thanks ^^

ACK 23fee90

@cdecker cdecker merged commit 219623c into master Jan 9, 2025
42 checks passed
@cdecker cdecker deleted the github-actions-ubuntu-22 branch January 9, 2025 10:15
@fanquake
Copy link
Contributor

Any particular reason why PRs that have the same changes are ignored: #7909 ?

@ShahanaFarooqui
Copy link
Collaborator Author

@fanquake The PR was not intentionally ignored. The CI broke due to updates in Poetry and the ubuntu-latest versions and I began working on a fix. While addressing the Poetry issue for macOS, I noticed that the symlink should also be removed and did that as part of the cleanup. I hope this clears up any confusion.

However, I overlooked removing the symlink from the doc/getting-started/getting-started/installation.md page. I wanted to reopen your PR to merge this change, but I am unable to do so because the branch has been deleted.

@fanquake
Copy link
Contributor

Fair enough. The branch in #7909 is restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants