This repository has been archived by the owner on Mar 14, 2021. It is now read-only.
Support CartCreate via SOAP #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CartCreate calls over SOAP requests require a wrapping 'Items' element around 'Item' elements in a different format to those used by REST requests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CartCreate calls over SOAP requests require a wrapping 'Items' element around 'Item' elements in a different format to those used by REST requests.
Unfortunately this is only for the 1.x branch, because our client's site is on an older version of PHP than is supported by the master branch, sorry! I'm sure the equivalent tweak in the master branch is just as simple.
As operations don't have any awareness of the request method, I couldn't think of any better way to format the request parameters than just passing in an argument from the calling code.
Perhaps there could be some way of transforming operations per request method?? I've no idea of the best way of doing that though.