address comments

src/helpers/approvals-satisfied.ts

@@ -30,19 +30,21 @@ export class ApprovalsSatisfied extends HelperInputs {
 
 export const approvalsSatisfied = async ({ teams, users, number_of_reviewers = '1', pull_number }: ApprovalsSatisfied = {}) => {
   const prNumber = pull_number ? Number(pull_number) : context.issue.number;
-  const reviews = await paginateAllReviews(prNumber);
-  const approverLogins = reviews
-    .filter(({ state }) => state === 'APPROVED')
-    .map(({ user }) => user?.login)
-    .filter(Boolean);
-  core.debug(`PR already approved by: ${approverLogins.toString()}`);
 
   const teamsList = updateTeamsList(teams?.split('\n'));
   if (!validateTeamsList(teamsList)) {
     core.setFailed('Teams input must be in the format "org/team" or "team". The org must be the same as the repository owner.');
     return false;
   }
   const usersList = users?.split('\n');
+
+  const reviews = await paginateAllReviews(prNumber);
+  const approverLogins = reviews
+    .filter(({ state }) => state === 'APPROVED')
+    .map(({ user }) => user?.login)
+    .filter(Boolean);
+  core.debug(`PR already approved by: ${approverLogins.toString()}`);
+
   const requiredCodeOwnersEntries =
     teamsList || usersList
       ? createArtificialCodeOwnersEntry({ teams: teamsList, users: usersList })

test/helpers/approvals-satisfied.test.ts

@@ -79,14 +79,6 @@ describe('approvalsSatisfied', () => {
   });
 
   it('should throw an error when passing teams override with full name and org is different than repo org', async () => {
-    mockPagination({
-      data: [
-        {
-          state: 'APPROVED',
-          user: { login: 'user1' }
-        }
-      ]
-    });
     const result = await approvalsSatisfied({ teams: 'owner/team2\nsomeOtherOrg/team1', pull_number: '12345' });
     expect(getRequiredCodeOwnersEntries).not.toHaveBeenCalled();
     expect(core.setFailed).toHaveBeenCalled();