fix(approvals-satisfied): remove @ from usernames

ExpediaGroup · Jul 9, 2024 · d138ad2 · d138ad2
1 parent 4a3a2d4
commit d138ad2
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/dist/431.index.js b/dist/431.index.js
diff --git a/dist/431.index.js.map b/dist/431.index.js.map
diff --git a/dist/676.index.js b/dist/676.index.js
diff --git a/dist/676.index.js.map b/dist/676.index.js.map
diff --git a/src/helpers/approvals-satisfied.ts b/src/helpers/approvals-satisfied.ts
@@ -71,7 +71,7 @@ export const approvalsSatisfied = async ({
       if (isTeam(teamOrUsers)) {
         return await fetchTeamLogins(teamOrUsers);
       } else {
-        return teamOrUsers.split(',');
+        return teamOrUsers.replaceAll('@', '').split(',');
       }
     });
     const codeOwnerLogins = uniq(loginsLists.flat());

diff --git a/test/helpers/approvals-satisfied.test.ts b/test/helpers/approvals-satisfied.test.ts
@@ -525,7 +525,7 @@ describe('approvalsSatisfied', () => {
       ]
     });
     const result = await approvalsSatisfied({
-      users: 'user1,user2',
+      users: '@user1,@user2',
       pull_number: '12345'
     });
     expect(octokit.pulls.listReviews).toHaveBeenCalledWith({ pull_number: 12345, repo: 'repo', owner: 'owner', page: 1, per_page: 100 });
@@ -543,7 +543,7 @@ describe('approvalsSatisfied', () => {
       ]
     });
     const result = await approvalsSatisfied({
-      users: 'user1,user2',
+      users: '@user1,@user2',
       pull_number: '12345'
     });
     expect(octokit.pulls.listReviews).toHaveBeenCalledWith({ pull_number: 12345, repo: 'repo', owner: 'owner', page: 1, per_page: 100 });