fix(manage-merge-queue): ensure queued for merge label is applied #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danadajian
force-pushed
the
fix-merge-queue
branch
from
e3cfa51 to
0de8ed1
Compare
|
🎉 This PR is included in version 1.62.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
bherrmann2
reviewed
Aug 9, 2024
| @@ -63,7 +63,7 @@ export const manageMergeQueue = async ({ | |||
| return removePrFromQueue(pullRequest); | |||
| } | |||
| const queuedPrs = await getQueuedPullRequests(); | |||
| const queuePosition = queuedPrs.length; | |||
| const queuePosition = queuedPrs.length + 1; | |||
There was a problem hiding this comment.
Length isn't an offset. Why the + 1?
There was a problem hiding this comment.
getQueuedPullRequests() will now return a list of open PRs with both the READY FOR MERGE and QUEUED FOR MERGE #X labels. Before, this was including the PR we are running this for
There was a problem hiding this comment.
So now, if there are 2 PRs in the queue, and this runs for a new PR that just got READY FOR MERGE, queuedPrs.length should be 2, and thus queuePosition for this new PR should be 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
READY FOR MERGEwithout a "queued for merge" label screws up queue assignment.