-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to Connect to NS article in New Expensify #55684
base: main
Are you sure you want to change the base?
Conversation
• Resource Update GH: Expensify/Expensify#463218 • Updating the formatting of the article https://help.expensify.com/articles/new-expensify/connections/netsuite/Configure-Netsuite • Mostly following the formatting of the classic article - https://help.expensify.com/articles/expensify-classic/connections/netsuite/Connect-To-NetSuite
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @CherylWalsh |
@MonilBhavsar @CherylWalsh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://46779e40.helpdot.pages.dev ⚡️ |
Capitalising the title to match https://help.expensify.com/articles/expensify-classic/connections/netsuite/Connect-To-NetSuite
Updating the title of the article with a capital "T" so it matches the title of this article https://help.expensify.com/articles/expensify-classic/connections/netsuite/Connect-To-NetSuite
Updated some minor formatting
Hey @CherylWalsh - here's the updated article for your review - https://46779e40.helpdot.pages.dev/articles/new-expensify/connections/netsuite/Connect-To-NetSuite Some background:
|
There are conflicts to resolve |
Explanation of Change
• Resource Update GH: https://github.com/Expensify/Expensify/issues/463218
• Updating the formatting of the article https://help.expensify.com/articles/new-expensify/connections/netsuite/Configure-Netsuite
• Mostly following the formatting of the classic article - https://help.expensify.com/articles/expensify-classic/connections/netsuite/Connect-To-NetSuite
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.