Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature/update pixdim4 for the final *bold outputs #2169

Merged
merged 17 commits into from
Dec 13, 2024

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Dec 11, 2024

Related to

Related to #2154 by @birajstha
Related to #2139 by @sgiavasis

Description

Merges

the changes

Added a node at the very end just before data-sink to compare and update/match the pixdim4 of the CPAC processed output with the native raw source bold image, as in figure below.
image

from #2154 onto 6b3c934.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the hotfix/1.8.7-1 branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy added this to the 1.8.7.post1 milestone Dec 11, 2024
@shnizzedy shnizzedy requested a review from a team December 11, 2024 22:00
@shnizzedy shnizzedy self-assigned this Dec 11, 2024
@shnizzedy shnizzedy marked this pull request as ready for review December 12, 2024 15:46
@shnizzedy shnizzedy merged commit 39507bd into hotfix/1.8.7-1 Dec 13, 2024
36 checks passed
@shnizzedy shnizzedy deleted the hotfix/1.8.7-pixdim4 branch December 13, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants