-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Add where-to-find information to missing resource nodeblock connection errors #2172
Draft
shnizzedy
wants to merge
17
commits into
many_pipes
Choose a base branch
from
inventory_error_message
base: many_pipes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
shnizzedy
added
feature
devops
improvement
engine
Internal implementation changes that may not be visible to users.
enhancement
labels
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
engine
Internal implementation changes that may not be visible to users.
enhancement
feature
improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #2171 by @shnizzedy
Description
Updates the "None of the listed resources are in the resource pool" error messages to include the resource sources inventoried by the utility added in #2171.
Technical details
Tests
Performs a
test_config
runC-PAC/CPAC/pipeline/test/test_engine.py
Line 180 in c6b3a18
anat-only
preconfigC-PAC/CPAC/pipeline/test/test_engine.py
Line 183 in c6b3a18
bids-standard/bids-examples/ds113b/sub-01
(which has functional but no anatomical files) and checksC-PAC/CPAC/pipeline/test/test_engine.py
Line 272 in c6b3a18
"can be output from"
, which is part of the new error messageC-PAC/CPAC/pipeline/resource_inventory.py
Line 652 in c6b3a18
Screenshots
Checklist
Update index.md
).many_pipes
branch of the repository.Developer Certificate of Origin
Developer Certificate of Origin