Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Add where-to-find information to missing resource nodeblock connection errors #2172

Draft
wants to merge 17 commits into
base: many_pipes
Choose a base branch
from

Conversation

shnizzedy
Copy link
Member

Fixes

Related to #2171 by @shnizzedy

Description

Updates the "None of the listed resources are in the resource pool" error messages to include the resource sources inventoried by the utility added in #2171.

Technical details

  • Moves pulling the bids-examples repo from happening in a single test to a session-level pytest fixture.
    • This fixture is crashing on Circle, need to figure that out before this will be ready to merge.

Tests

Performs a test_config run

analysis_level="test_config",
with the anat-only preconfig
c = Preconfiguration("anat-only")
on bids-standard/bids-examples/ds113b/sub-01 (which has functional but no anatomical files) and checks
assert "can be output from" in caplog.text
that the log includes the string "can be output from", which is part of the new error message
output += f"'{resource}' can be output from:\n"

Screenshots

screenshot of "[!] C-PAC says: None of the listed resources are in the resource pool" error message

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the many_pipes branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy added feature devops improvement engine Internal implementation changes that may not be visible to users. enhancement labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops engine Internal implementation changes that may not be visible to users. enhancement feature improvement
Projects
Status: 🚫 Blocked
Development

Successfully merging this pull request may close these issues.

1 participant