Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable/2009 #34

Open
wants to merge 129 commits into
base: master
Choose a base branch
from
Open

Stable/2009 #34

wants to merge 129 commits into from

Conversation

NUAAwanghe
Copy link

vec.h
vec_cmp has a bug
my machine is 64 bit, _v(cmp) is signed long type, so vec_len(v1) - vec_len(v2) is a big number
here is my test code:
int * v1 = vec_new(int, 10);
int * v2 = vec_new(int, 10);
vec_set(v1, 1);
vec_set(v2, 1);

vec_alloc(v2, sizeof(int)*10);
_vec_len(v2) = vec_len(v2) + 10;
int val = vec_cmp(v1, v2);

the val should be -1, but due to the bug it is 1, v1 always more than v2

ayourtch and others added 30 commits September 9, 2020 21:54
@ayourtch
misc: Initial changes for stable/2009 branch
fb6d768 
Change-Id: Ibb982c877427c8382a30ee561c23d878adc9c28d
Type: docs
Signed-off-by: Andrew Yourtchenko <[email protected]>
@ayourtch
misc: edit the MAINTAINERS entries for crypto plugins for common style
f96ce15 
Change-Id: Ic40bf11210cf1c36420578281f5a42668bad9801
Type: docs
Signed-off-by: Andrew Yourtchenko <[email protected]>
(cherry picked from commit f8b3193)
@ayourtch
dpdk: fix coverity defect #214232, #182930
f1b7953 
Type: fix

Signed-off-by: Chenmin Sun <[email protected]>
Change-Id: Ie328834159687cdb4314c37d36697f2fb9081fbd
(cherry picked from commit 504bcb7)
@ayourtch
af_xdp: documents incompatibility with 1GB hugepages and high buffers…
758e677 
…-per-numa.

Type: docs
Change-Id: If8602d4b73cc1f04e42d19b8df60a05f67aa90c9
Signed-off-by: Mohammed Hawari <[email protected]>
(cherry picked from commit 5d2091d)
@AloysAugustin @ayourtch
quic: fix coverity warning
6f1a86f 
Change-Id: Ic31cde8564a0705710d91e0a7b90dcc6cf2f8db6
Type: fix
Signed-off-by: Aloys Augustin <[email protected]>
@Millnert @ayourtch
misc: selinux fixes (packet_socket r/w)
cb94290 
vpp-20.05 on up-to-date Centos 7.8 host with enforcing SELinux fails to
create a host-interface due to two missing SELinux-permissions:

vpp_t self:packet_socket { read write }

This simple patch adds these two permissions. Tested successfully on
local installation.

The steps to reproduce:

$ ip link add vpeer-host type veth peer name vpeer-vpp
vpp# create host-interface name vpeer-vpp
create host-interface: Permission denied (errno 13)
[...]
$ semodule -i vpp-packet-socket.pp
vpp# create host-interface name vpeer-vpp
host-vpeer-vpp

Type: fix
Ticket: VPP-1931
Change-Id: I2b3d92b27b9a9f26aa1c85af2946b15e83e27944
Signed-off-by: Martin Millnert <[email protected]>
(cherry picked from commit 6884935)
@bganne @ayourtch
ikev2: fix memory leaks
c13aab8 
 - make sure everything is freed on cleanup
 - reuse already allocated vectors where possible

Type: fix

Change-Id: Ibd8da1edb37126522dc2d525596521d32dceb73a
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 730cec8)
@mgsmith1000 @ayourtch
l2: fix null deref in l2_to_bvi()
649ba15 
Type: fix

Static analysis identified a possible null pointer dereference. It
was introduced by a recent patch which expanded the DMAC comparison
on inbound packets on a BVI interface to include any secondary MAC
addresses which were added to an interface.

Check if the pointer is null before dereferencing.

Change-Id: Ic2afe2b062eda32977e05bf3f98d82c1fe64620c
Signed-off-by: Matthew Smith <[email protected]>
(cherry picked from commit 78681de)
@bganne @ayourtch
vlib: fix call to vlib_get_node_by_name
a238082 
Type: fix

Change-Id: I1b4f52e186165b04db5bd5f11058dc77b647bc94
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 268e3b6)
@ayourtch
wireguard: coverity fixes
ec8a577 
Type: fix

Signed-off-by: Neale Ranns <[email protected]>
Change-Id: Ib1eabbc87a573c660ac251602d631f167928259b
(cherry picked from commit 76770fd)
@florincoras @ayourtch
vcl: always fill buffer or drain rx fifo
89bdb83 
Type: improvement

Signed-off-by: Florin Coras <[email protected]>
Change-Id: Ibbe438aa6f2fe6d9f55c56ca6d3aec1a29b32cad
(cherry picked from commit 4a2c794)
@bganne @ayourtch
build: fix build for Debian 9 and Debian 10
047eebf 
Type: fix

Change-Id: Ic07d0ae313b32e420ba93693cb75960a86f752a9
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 3f0ae66)
@ayourtch
ikev2: fix copy-paste error when freeing memory
57b16c6 
Type: fix

Change-Id: If44c807d188b3e88d819f4132d73e6a34402a525
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit 999395c)
@yicwang @ayourtch
build: fix the the build on centos/rhel 8
748bf82 
1. Remove uncessary runtime dependency;
2. Add missing build dependency;
3. Fix runtime dependency for api-python3 RPM;

Type: make

Change-Id: I2700f1a15112effba8d1527aca6467158f81f486
Signed-off-by: Yichen Wang <[email protected]>
(cherry picked from commit 466872f)
@dmarion @ayourtch
crypto-native: fix issues detected by coiverity
ddd8c0f 
Type: fix
Change-Id: Id61aa407eeeb4d44cf47ed39283a0c79ed3abbee
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit 139a6ae)
@ayourtch
crypto: Crypto SW Scheduler Coverity Warnings
c71dad4 
Type: fix

Signed-off-by: Neale Ranns <[email protected]>
Change-Id: I7f98d0c7847ecc40b90b78e5ae83f320575be310
(cherry picked from commit 69f77a3)
wireguard: increase FIB source priority
58db34c 
Type: fix

Signed-off-by: Neale Ranns <[email protected]>
Change-Id: Icc1c458474d357c7d9b3b4df1897500de0c314a1
(cherry picked from commit a26b0d1)
@glazychev-art @ayourtch
wireguard: fix handshake procedure
911d756 
Type: fix

Change-Id: I96e8c5c9c792b1d9aefd39ce3e240d220827b7d1
Signed-off-by: Artem Glazychev <[email protected]>
(cherry picked from commit cf52788)
@ayourtch
lisp: fix crash with arp and packet trace on
7bae491 
With packet trace on, VPP crashes when an arp packet arrives. This patch
fixes the crash and also ensures that the packet trace displays the eid
info.

Type: fix
Signed-off-by: Onong Tayeng <[email protected]>
Change-Id: Iaad09a5e2b33e931ab9bd7bc3d4573b5ed5e4bfd
(cherry picked from commit a3960a8)
@sknat @ayourtch
quic: Clean quic_crypto_setup_cipher
6c25154 
Type: fix

Change-Id: I4c19636c2be8a577c6cba272708cb04bcc24785b
Signed-off-by: Nathan Skrzypczak <[email protected]>
(cherry picked from commit 8847749)
@ayourtch
nat: endian mismatch
1f18c50 
Type: fix

Change-Id: Icf6ce0ddb5fe9d078503e9d9ff7e7b26423f53f8
Signed-off-by: Filip Varga <[email protected]>
(cherry picked from commit 2fe2537)
@ayourtch
nat: Fix next feature for ED with multiple workers
95a77a2 
Multiple (> 1) workers leads to handoff node being enabled.
This node pops next feature index to nat.arc_next to make sure
that packet will be pushed to the next feature in the arc.

But node nat44-ed-in2out-output also pops next feature and changes
arc_next. So actual next feature will be skipped in that case.

It leads to all nat44-ed-in2out packets being dropped if we have
multiple workers (handoff node enabled).

To resolve this a new node was added (nat-pre-in2out-output) to fill
arc_next in single worker case and multiple worker case is already
handled by handoff node.

Type: fix
Signed-off-by: Vladimir Isaev <[email protected]>
Change-Id: I9dfba68f00164d2d5ab867224871811bef4411ed
(cherry picked from commit 8fb4d10)
@dmarion @ayourtch
avf: fix race between avf process node and avf_delete_if(...)
2ee0098 
It may happen that process node is suspended while it waits for response
from adminq and during that time CLI or API process can call
avf_delete_if. When avf process node resumes, it may happen that device
is not there anymeore.

This patch delegates interface deletion to process node, so CLI/API
process just sends signal instead of deleting device instance itself.

Type: fix

Change-Id: I7f12e12df3071650f6e60ad7eb5af23b7acfe335
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit 66bb7dd)
@ayourtch
lisp: fix lisp|one_eid_table_dump's local|remote options in vat
d5f713c 
The local|remote options to vat's lisp|one_eid_table_dump api command
does not print the eid details instead it produces the following error
messages:

    Filter error, unknown filter: 1
    Filter error, unknown filter: 2

Type: fix
Signed-off-by: Onong Tayeng <[email protected]>
Change-Id: I000c290b400dbf39bd883d57115923167092c9bd
(cherry picked from commit 2237cc8)
@ayourtch
lisp: fix spelling mistake in option name
c669272 
In the vat help msg for one_add_del_l2_arp_entry the IP address option
is misspelled as "ip4 <ip4>" when it should have been "ip <ip4>".

Type: fix
Signed-off-by: Onong Tayeng <[email protected]>
Change-Id: Id4058a3ddfdb78b840d7e5a3c330e67b393f5d3b
(cherry picked from commit 8c6ba29)
@ayourtch
lisp: fix help msg of show eid-table command
a14f367 
The lisp|one show eid-table command's help msg does not display the
available options. This patch fixes that.

  show lisp eid-table [local|remote|eid <eid>]
  show one eid-table [local|remote|eid <eid>]

Type: fix

Signed-off-by: Onong Tayeng <[email protected]>
Change-Id: Id39148db2ff291a7fe859830c1488b69ccd15c05
(cherry picked from commit b418c39)
@ayourtch
lisp: fix vat crash with one_add_del_local_eid api
21cbdc7 
VAT crashes when the one_add_del_local_eid api is invoked with mac
address as eid.

Type: fix

Signed-off-by: Onong Tayeng <[email protected]>
Change-Id: I29e246f6cad4b350fec52d54e94dbed586d488c4
(cherry picked from commit 5f473c0)
@ayourtch
wireguard: Fix for tunnel encap
6efd393 
Type: fix

add UT for sneding handshale init and transport packets

Signed-off-by: Neale Ranns <[email protected]>
Change-Id: Iab1ed8864c666d5a0ae0b2364a9ca4de3c8770dc
(cherry picked from commit d75a2d1)
@dmarion @ayourtch
avf: add assert to ensure that adminq is used only from avf process
97109b1 
Type: improvement
Change-Id: Ib64c9b8207776986656e5a26c13a221edc6cc950
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit 698eeb1)
@ayourtch
vppapigen: crcchecker: report deprecated messages
ec7e8d8 
Report if the messages were marked as deprecated,
but not yet deleted.

Useful for building the release notes and comparing
between the releases.

Also, put the dict_compare() call into the report(),
since latter always consumes the output of the former.

Change-Id: Iceab3e94ff66da931a4669b612026bd162dd5d1a
Type: improvement
Signed-off-by: Andrew Yourtchenko <[email protected]>
(cherry picked from commit 62bd50d)
Filip Tehlar and others added 29 commits November 26, 2020 15:02
@ayourtch
ikev2: fix initial contact cleanup
8b69f75 
When looking for existing SA connection to clean up search all per
thread data, not only current one.

Type: fix

Change-Id: I59312e08a07ca1f474b6389999e59320c5128e7d
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit e7c8396)
@ayourtch
ikev2: prevent crash after no IP address
83c70b7 
Type: fix
Ticket: VPP-1900

This fixes a crash when initiating IKE connection using interface
without any IP address.
It also ensures that the IKE connection is automatically retried once the
interface obtains an address.

Signed-off-by: jan_cavojsky <[email protected]>
Signed-off-by: Filip Tehlar <[email protected]>
Change-Id: Ia1919c349e64b3a0a4198365e075e177e3ba3de5
(cherry picked from commit 6960da5)
@ayourtch
ikev2: fix setting responder/initiator addresses
233b12d 
Type: fix

Change-Id: Ic406aa914d92e802a5fb0f27c2ffa1b98db012b0
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit ec112e5)
@ayourtch
ikev2: support sending requests from responder
a81bcf3 
Type: improvement
Ticket: VPP-1894

Change-Id: I5a24a48416bca2ffbd346cdaa813fb25801e6c9b
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit edf2900)
@ayourtch
ikev2: fix memory leak
f7fd0e7 
Type: fix

Change-Id: I33c38c791cc9a28898de402ae831c4862073eb2d
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit b8bc2f1)
@ayourtch
ikev2: cli for disabling dead peer detection
56d7125 
Type: feature

Change-Id: I0db0a9b2f872753fa64d27335838cb34645a9ee8
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit af4a414)
@ayourtch
ikev2: increase tick interval in process node
31b44a7 
This helps to resolve sporadic failures in unit tests.

Type: fix

Change-Id: I3abd77ed74310f9729a841e8569eafe6d7758dcb
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit 761f8f0)
@ayourtch
ikev2: fix reply during rekey
f6deabd 
Type: fix

Change-Id: If87f4b8ae92508215fe91178958fe2ddb91e5a35
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit 68ad625)
@ayourtch
ikev2: add option to disable NAT traversal
8035ffe 
Type: feature
Ticket: VPP-1935

Change-Id: I705f84047b112279377590157a1c7b4a34f693d2
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit d7fc12f)
@ayourtch
ikev2: fix udp encap
cbc3dc0 
Type: fix

Change-Id: I8c66f79f2d8cfff7c6d45e1fc5b529ffb3941491
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit 67b8a7f)
@ayourtch
ikev2: fix msg IDs generation
6d878f3 
Type: fix

Change-Id: Id922895c269f0d2450e55fcb6871b6857f443462
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit f6b02e0)
@ayourtch
ikev2: add tests for DPD
29ad988 
Type: test

Change-Id: I9c1129a8596344551f3f8f2e029846d22511482e
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit 2008e31)
@ayourtch
ikev2: fix memleak when tunnel protect fails
49de328 
Type: fix

Change-Id: I1d278fc2b03b948c054ff1686315635ac0278ae8
Signed-off-by: Filip Tehlar <[email protected]>
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 7270820)
@bganne @ayourtch
ikev2: respect punting only for ipv4
186f018 
IPSec punting to IKEv2 is valid only for NAT-T in IPv4.
Fix coverity CID 214915.

Type: fix

Change-Id: I6f2db38abf179565316f50c5d47c78acce3a0d01
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit d9ed0b6)
@ayourtch
ikev2: fix issue when sending multiple requests at once
6e13acc 
Type: fix

Change-Id: I8ed556de4370a03d10c56cce101cd5ea0d0aaf8b
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit 38340fa)
@ayourtch
ikev2: better handling when no IKE DH configured
0e68a7c 
Type: improvement

Change-Id: I4289d20adaa3f2872889d5dbaafd9c025df8aca8
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit e1ab06c)
@ayourtch
ip-neighbor: Send API event when neighbor is removed
b72fb31 
Type: fix

Signed-off-by: Neale Ranns <[email protected]>
Change-Id: I9952497a108bac26445af95c28d4eed46099c2fc
@ayourtch
rdma: fixed UAR writing at tx
e7a1006 
Change-Id: Id81b4d27845c4e91cef90a4b8649662942d3cba1
Signed-off-by: Mohammed Hawari <[email protected]>
Type: fix
(cherry picked from commit 3ef653a)
stats: missing dimension in stat_set_simple_counter
007bd2f 
A simple counter is a two dimensional array by threads and
counter index. 28017 introduced an error missing the first
dimension.

If a vector is updated at the same time as a client reads,
an invalid pointer my result. This will be caught by the
optimistic locking after copying out the data, but if
following a pointer outside of the stat segment then
the stat client would crash. Add suitable boundary checks
for access to stat memory segment.

Fixes: 7d29e32
Type: fix
Signed-off-by: Ole Troan <[email protected]>
Change-Id: I94f124ec71d98218c4eda5d124ac5594743d93d6
(cherry picked from commit 65c56c8)
Signed-off-by: Elias Rudberg <[email protected]>
@bganne
ikev2: fix nat traversal
7847f17 
Type: fix

Change-Id: Ie723cf680745ec2292a15e2df05c1821436dba19
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit 18107c9)
@dwallacelf
build: fix centos-8 'make install-deps' enable PowerTools repo
a23dd5d 
- The name of the powertools repo was changed [0]
  in centos-8 from 'PowerTools' to 'powertools'.
  Retrieve the correct name from 'dnf repolist all'
  instead of hard coding it.

[0] https://git.centos.org/rpms/centos-repos/c/b759b17557b9577e8ea156740af0249ab1a22d70

Type: fix

Signed-off-by: Dave Wallace <[email protected]>
Change-Id: Ic1402e671eb1d70dec429bab82ad18d8251f4eef
(cherry picked from commit 1affb31)
@ayourtch
nat: avoid hairpinning infinite loop problem
3b82d3e 
Fix in nat44 hairpinning code to check if anything was actually
changed in the snat_hairpinning() routine, and return 0 if nothing
changed. This helps avoid an infinite loop repeating the three
nodes nat44-hairpinning-->ip4-lookup-->ip4-local in case there
was no change. Also add a corresponding test case.

This is essentially a cherry-pick of change 30284 but the
automatic cherry-picking did not work because of some filename
changes.

Type: fix

Signed-off-by: Elias Rudberg <[email protected]>
Change-Id: I21a59ae7423f40abeff9fc0411330da58b3011f0
@pvinci @dwallacelf
docs: fix missing quotes in ubuntu install instructions
1e44cf5 
type: docs

Change-Id: Ifa09b63924f4b7bf2719bba6ada0e1122407641c
Signed-off-by: Paul Vinciguerra <[email protected]>
(cherry picked from commit ac9a585)
@pvinci @dwallacelf
docs: update list of plugins
d1598d4 
The list of plugins is outdated.

This change introduces a dynamically
generated list of the plugins along with their descriptions,
extracted directly from the sources.

Type: docs

Change-Id: Icb7b65e6b45289e257d71a1c18d10f62ced59cbe
Signed-off-by: Paul Vinciguerra <[email protected]>
(cherry picked from commit 630ca99)
@dwallacelf
build: add missing openssl-devel package for centos-8 vpp-ext-deps
14bfb66 
- In a new centos-8 installation, vpp-ext-deps fails on missing
  ssl.h header file after 'make install-deps'.

Type: fix

Signed-off-by: Dave Wallace <[email protected]>
Change-Id: I521d817dd1f1e21aff427d98b9832ea7c7b89339
@dwallacelf
docs: vpp stateless traffic generator
4f88004 
Add a use-case writeup.

Type: docs

Signed-off-by: Dave Barach <[email protected]>
Change-Id: Ib6e79e80455edbdeedcc96943dd98f16c57c559e
(cherry picked from commit b8f6122)
@dwallacelf
ikev2: test responder behind NAT
8b4bd27 
Type: test
Ticket: VPP-1903

Change-Id: I7fab6931833d6e253b7b921172825387302d8f70
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit 027d813)
@jlinkes
dpdk: disable i40evf in favor of iavf patch
4f7b92f 
Fix an issue where multiple VPP instances with DPDK starting at the
same time would not initialize VFs properly. This is done by using the
iavf PMD (where the issue can't be reproduced) instead of the i40evf
PMD.

Type: fix
Ticket: VPP-1943
Signed-off-by: Juraj Linkeš <[email protected]>
Change-Id: Idcc48088c7d66a76da2b4675c02c7c115706c8b3
@bganne
ipsec: fix AES CBC IV generation (CVE-2022-46397)
b6e090c 
For AES-CBC, the IV must be unpredictable (see NIST SP800-38a Appendix
C). Chaining IVs like is done by ipsecmb and native backends for the
VNET_CRYPTO_OP_FLAG_INIT_IV is fully predictable.
Encrypt a counter as part of the message, making the (predictable)
counter-generated IV unpredictable.

Fixes: VPP-2037
Type: fix

Change-Id: If4f192d62bf97dda553e7573331c75efa11822ae
Signed-off-by: Benoît Ganne <[email protected]>
@vvalderrv vvalderrv mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.