Skip to content

Commit

Permalink
Fix warning and error management of apio verilator linter
Browse files Browse the repository at this point in the history
  • Loading branch information
cavearr committed Dec 26, 2024
1 parent c3347b3 commit 29b0cf8
Show file tree
Hide file tree
Showing 8 changed files with 801 additions and 65 deletions.
17 changes: 9 additions & 8 deletions app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"engines": {},
"node": ">= 21.1.0",
"dependencies": {

"ace-builds": "~1.4.12",
"adm-zip": "0.4.7",
"alertifyjs": "~1.13.1",
Expand Down Expand Up @@ -76,6 +75,7 @@
"node-emoji": "~1.8.1",
"node-lang-info": "~0.2.1",
"openurl": "~1.1.1",
"proper-lockfile": "^4.1.2",
"rmdir": "~1.2.0",
"rsyncwrapper": "~2.0.1",
"select2": "~4.1.0-rc.0",
Expand All @@ -87,9 +87,8 @@
"sudo-prompt": "~8.2.0",
"svg-pan-zoom": "~3.4.1",
"svgo": "~0.7.2",
"tmp": "0.0.33",
"proper-lockfile": "^4.1.2",
"sweetalert2": "^11.14.4"
"sweetalert2": "^11.14.4",
"tmp": "0.0.33"
},
"readme": "../README.md",
"keywords": [
Expand Down
3 changes: 2 additions & 1 deletion app/scripts/graphics/joint.shapes.js
Original file line number Diff line number Diff line change
Expand Up @@ -2819,6 +2819,7 @@ joint.shapes.ice.WireView = joint.dia.LinkView.extend({
joint.dia.LinkView.prototype.initialize.apply(this, arguments);

var self = this;

setTimeout(function () {
var size = self.model.get("size");

Expand All @@ -2841,7 +2842,7 @@ joint.shapes.ice.WireView = joint.dia.LinkView.extend({
}

self.updateWireProperties(size);
self.updateBifurcations();
self.updateBifurcations();i
}, 0);
},

Expand Down
4 changes: 3 additions & 1 deletion app/scripts/services/graph.js
Original file line number Diff line number Diff line change
Expand Up @@ -1518,7 +1518,9 @@ function updateWiresOnObstacles() {
commandManager.listen();
}

self.fitContent();

self.updateWires();
self.fitContent();

this.enableAutoRouting();
if (callback) {
Expand Down
13 changes: 11 additions & 2 deletions app/scripts/services/tools.js
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ angular
});
}
}else{
let re = /%Error:\s+(\w+\.v):(\d+):(\d+):\s*(syntax error,.*)$/gm;
re = /%Error:\s+(\w+\.v):(\d+):(\d+):\s*(syntax error,.*)$/gm;

while ((matchError = re.exec(stdout))) {
codeErrors.push({
Expand All @@ -920,7 +920,16 @@ angular
});
}

console.log('ERROR_TASK',code);
re = /%(Error|Warning)(-[A-Z0-9]+)?: main\.v:(\d+):(\d+): (.*?)[\r\n]/g;
while ((matchError = re.exec(stdout))) {
codeErrors.push({
line: parseInt(matchError[3]),
msg: matchError[5].trim(),
type: matchError[1].toLowerCase() // Convert 'Error' or 'Warning' to lowercase for type
});
}
console.log('ERRORS',codeErrors);
//console.log('ERROR_TASK',code);
}

// - Yosys errors
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/services/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ angular.module('icestudio')
iceConsole.log("APIO VERSION "+common.APIO_VERSION+' / '+iceStudio.toolchain.apio);

if(iceStudio.toolchain.apio >= '0.9.6' || common.APIO_VERSION === common.APIO_VERSION_DEV){
let args='--install';
let args='install';
let edge='packages';
/* switch(pkg){
case 'drivers':
Expand Down
Loading

0 comments on commit 29b0cf8

Please sign in to comment.