Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMH improvements #857

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
4 changes: 2 additions & 2 deletions Resource Packs/Mod Menu Helper/assets/fo/lang/en_us.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"modmenu.summaryTranslation.entity_texture_features": "OptiFine's Random & Emissive Entities\n§3§l📥§r§9🛠§8 Random mobs, emissivity, eye blinking, ...",
"modmenu.summaryTranslation.entityculling": "Stops rendering mobs behind walls\n§8🛠 (only advanced options)",
"modmenu.summaryTranslation.fabricskyboxes": "Custom Sky\n§3§l📥§r§9🛠§8 Expand the mod to configure (click ▼ on icon)",
"modmenu.summaryTranslation.fabrishot": "Take 4K screenshots with F9\n§9🛠§8 Override F2, resolution, keybind, ...",
"modmenu.summaryTranslation.fabrishot": "Take 4K screenshots with <keybind 'key_key.fabrishot.screenshot'>\n§9🛠§8 Override <keybind 'key_key.screenshot'>, resolution, keybind, ...",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even when MMH one is correct, the pause menu one won't be... But it's better than nothing I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing with MM 12.0.0 for 1.21.3 and TP API 2.5.1+1.21.3, the mod keybind crashed while the vanilla one worked. Maybe due to not being available in early loading yet?

[17:25:18] [Render thread/ERROR]:Reported exception thrown!
net.minecraft.class_148: Rendering screen
	at knot/net.minecraft.class_757.method_3192(class_757.java:558) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1523(class_310.java:1352) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1514(class_310.java:933) [client-intermediary.jar:?]
	at knot/net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.9.jar:?]
Caused by: java.lang.NullPointerException: Cannot invoke "String.length()" because "string" is null
	at knot/eu.pb4.placeholders.api.parsers.TagLikeParser$Format.findFirst(TagLikeParser.java:368) ~[placeholder-api-2.5.1+1.21.3.jar:?]
	at knot/eu.pb4.placeholders.impl.textparser.SingleTagLikeParser.handleLiteral(SingleTagLikeParser.java:21) ~[placeholder-api-2.5.1+1.21.3.jar:?]
	at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parse(TagLikeParser.java:82) ~[placeholder-api-2.5.1+1.21.3.jar:?]
	at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parseNodes(TagLikeParser.java:75) ~[placeholder-api-2.5.1+1.21.3.jar:?]

"isxander-main-menu-credits.fabrishot": "Take 4K screenshots with F9",
"modmenu.summaryTranslation.fadeless": "§6🔀§r Removes loading fade animation\n§8§m🛠§8 (no options)",
"modmenu.summaryTranslation.fastquit": "Quits from singleplayer instantly\n§9🛠§8 Toasts, indicator, ...",
Expand Down Expand Up @@ -55,7 +55,7 @@
"modmenu.summaryTranslation.sodium": "Optimizes rendering, better FPS\n§9🛠§8 In Video Settings: optimizations",
"sodium.options.buttons.donate": "Support Sodium!",
"modmenu.summaryTranslation.yosbr": "Modpack's default options\n§9🛠§8 To reset, see FO wiki",
"modmenu.summaryTranslation.zoomify": "Zoom by holding C\n§9🛠§8 Distance, cinematic camera, keybind, ...",
"modmenu.summaryTranslation.zoomify": "Zoom by holding <keybind 'key_zoomify.key.zoom'>\n§9🛠§8 Distance, cinematic camera, keybind, ...",
"fo.resourcePack.fastbettergrass": "§7OptiFine's Better Grass (fast)§r\n§4Must be the first to work§r",
"menu.shareToLan": "Open to Internet",
"lanServer.title": "Open to Internet",
Expand Down