Skip to content

Commit

Permalink
Merge upstream/master.
Browse files Browse the repository at this point in the history
  • Loading branch information
bgrainger committed Apr 30, 2024
2 parents b86946b + 7ad52d4 commit ac2fac5
Show file tree
Hide file tree
Showing 174 changed files with 57,317 additions and 19,716 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/codeowners-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
steps:
- uses: 'actions/checkout@v4'
- name: 'Run Codeowners merge check'
uses: 'fox-forks/code-owner-self-merge@8b5015c0e9a2dc8401cb3cde1bce517b044a99af'
uses: 'OSS-Docs-Tools/code-owner-self-merge@a04a7103f8ab9b1abdc60a2a742ac090e1869e52'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}'
with:
merge_method: 'squash'
ownerNoPings: '["@hyperupcall"]'
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ repos:
exclude: '^src/(package-lock.json|test/openutau-ustx/bulaomeng.ustx.yaml|test/kustomization/labels.json|bin/.*)$'
args:
[
'-Lcrate,ninjs,ans,specif,seh,specifid,deriver,isnt,tye,forin,dependees,rouge,interm,fo,wast,nome,statics,ue,aack,gost,inout,provId,handels,bu,testng,ags,edn,aks,te,decorder,provid,branche,alse,nd,mape,wil,clude',
'-Lcrate,ninjs,ans,specif,seh,specifid,deriver,isnt,tye,forin,dependees,rouge,interm,fo,wast,nome,statics,ue,aack,gost,inout,provId,handels,bu,testng,ags,edn,aks,te,decorder,provid,branche,alse,nd,mape,wil,clude,wit,flate',
]
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- [Recommended Extensions](#recommended-extensions)
- [Schema Authoring](#schema-authoring)
- [Best practices](#best-practices)
- [Avoiding overconstraint](#avoiding-overconstraint)
- [Undocumented Features](#undocumented-features)
- [API Compatibility](#api-compatibility)
- [Troubleshooting](#troubleshooting)
Expand Down Expand Up @@ -108,6 +109,14 @@ There is an [unofficial draft-07][draft-07-unofficial-strict] schema that uses J
[base-04]: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/base-04.json
[draft-07-unofficial-strict]: https://json.schemastore.org/metaschema-draft-07-unofficial-strict.json

#### Avoiding overconstraint

Sometimes, constraints do more harm than good. For example, [cron strings](http://pubs.opengroup.org/onlinepubs/7908799/xcu/crontab.html) validation regexes. False positives are likely as due to their complexity and abundance of implementations; and, when there is an error, the error message isn't helpful. Such cases can include:

- cron regexes
- string-embedded DSLs
- SSH URLs, HTTPS URLs, and other complex URIs

### Undocumented Features

The use of undocumented features in schemas is permitted and encouraged. However they must be labeled as such.
Expand Down
Loading

0 comments on commit ac2fac5

Please sign in to comment.