Deserialize integer/long JSON into double single-arg constructors #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmoten
changed the title
davidmoten
force-pushed
the
int-to-double
branch
from
1426158 to
64e6697
Compare
cowtowncoder
added
the
cla-needed
|
Thank you! I hope to review this soon, get it merged. ONe process thing: if we haven't yet gotten a CLA (only needs to be done once so if there is one, that's good), we'd need one from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and the usual way is to print it, fill & sign, scan/photo, email to |
|
contributor agreement has been sent |
|
CLA received, hoping to merge tomorrow. Thank you for sending CLA so quickly! |
cowtowncoder
removed
the
cla-needed
|
Ok looks good but will need to wait until tomorrow to merge (ran out of time tonight, wrt merge to |
cowtowncoder
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4453
This PR ensures that deserialization of integer/long json like
5or12345678901occurs without error when the target class has a single argument constructor of argument typedouble. This ensures consistency with the treatment by Jackson of deserialization into multi-arg constructors (annotated with@JsonProperty).Tests provided give full coverage of changed code and I've also tested that expected preferences are applied when multiple constructors are available.
Note that other types (like
floatat least) will be handled in another PR.