Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove final on method BeanSerializer.serialize() #4483

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Remove final on method BeanSerializer.serialize() #4483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b070f32
Remove final on method BeanSerializer.serialize. This keeps consisten…
mluckam Apr 17, 2024
78b2bc2
Add release notes
cowtowncoder Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions release-notes/CREDITS-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1780,3 +1780,7 @@ Teodor Danciu (teodord@github)
* Reported #4464: When `Include.NON_DEFAULT` setting is used, `isEmpty()` method is
not called on the serializer
(2.18.0)

Matthew Luckam (mluckam@github)
* Contributed #4483: Remove `final` on method BeanSerializer.serialize()
(2.18.0)
2 changes: 2 additions & 0 deletions release-notes/VERSION-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Project: jackson-databind
(fix by Joo-Hyuk K)
#4472: Rework synchronized block in `TypeDeserializerBase`
(contributed by @pjfanning)
#4483: Remove `final` on method BeanSerializer.serialize()
(contributed by Matthew L)

2.17.1 (not yet released)

Expand Down
3 changes: 2 additions & 1 deletion src/main/java/com/fasterxml/jackson/databind/ser/BeanSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ protected BeanSerializerBase asArraySerializer()
* {@link BeanPropertyWriter} instances.
*/
@Override
public final void serialize(Object bean, JsonGenerator gen, SerializerProvider provider)
// note: was final before 2.18
public void serialize(Object bean, JsonGenerator gen, SerializerProvider provider)
throws IOException
{
if (_objectIdWriter != null) {
Expand Down