Skip to content

Commit

Permalink
Simplify dependency declarations; all core components via parent pom
Browse files Browse the repository at this point in the history
  • Loading branch information
cowtowncoder committed Jan 17, 2025
1 parent e0ca2d6 commit cd4b3bb
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 52 deletions.
12 changes: 2 additions & 10 deletions avro/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,8 @@ abstractions.
</properties>

<dependencies>
<!-- Hmmh. Need annotations for introspection... -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>
<!-- and databind for Avro Schema generation... -->
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
<!-- Core deps from parent -->

<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
Expand Down
11 changes: 0 additions & 11 deletions cbor/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,6 @@ encoded data using Jackson abstractions (streaming API, data binding, tree model
</properties>

<dependencies>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>

<!-- annotations for testing -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<scope>provided</scope>
</dependency>
</dependencies>

<build>
Expand Down
14 changes: 0 additions & 14 deletions ion/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,6 @@ tree model)
<version>1.11.9</version>
</dependency>

<!-- Extends Jackson core, databind -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>

<!-- will come from parent pom for later versions -->
<dependency>
<groupId>org.hamcrest</groupId>
Expand Down
10 changes: 9 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,19 @@
</properties>

<dependencies>
<!-- all dataformats extend core so just include here -->
<!-- all dataformats extend core and databind, annotations; include here -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>

<!-- 11-Jan-2025, joohyukkim: For JSTEP-10, migrate to JUnit5 -->
<dependency>
Expand Down
4 changes: 0 additions & 4 deletions protobuf/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ abstractions.
<version>4.0.3</version>
</dependency>

<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
</dependencies>

<build>
Expand Down
12 changes: 0 additions & 12 deletions smile/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,6 @@ tree model)
</properties>

<dependencies>

<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>

<!-- We need annotations just for testing -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<scope>provided</scope>
</dependency>
</dependencies>

<build>
Expand Down

0 comments on commit cd4b3bb

Please sign in to comment.