Don't fail on delete errros Just send a warning BNN-394 #resolve (#355)

FenixEdu · May 19, 2020 · 9b6914a · 9b6914a
1 parent 1c7a99d
commit 9b6914a
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/bennu-io/src/main/java/org/fenixedu/bennu/io/domain/DriveAPIStorage.java b/bennu-io/src/main/java/org/fenixedu/bennu/io/domain/DriveAPIStorage.java
@@ -10,6 +10,8 @@
 import org.fenixedu.bennu.core.util.CoreConfiguration;
 import org.fenixedu.jwt.Tools;
 import org.joda.time.DateTime;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.File;
 import java.io.IOException;
@@ -20,6 +22,8 @@
 
 public class DriveAPIStorage extends DriveAPIStorage_Base {
 
+    private static final Logger logger = LoggerFactory.getLogger(DriveAPIStorage.class.getName());
+
     static {
         Unirest.config().reset();
         Unirest.config().followRedirects(false);
@@ -78,7 +82,15 @@ private boolean deleteFile(final String fileId) {
                 .header("Authorization", "Bearer " + getAccessToken())
                 .header("X-Requested-With", "XMLHttpRequest")
                 .asString();
-        return response.getStatus() == 204;
+        if (response.getStatus() != 204) {
+            if (logger.isWarnEnabled()) {
+                logger.warn("Failed to delete file: " + fileId + ". Got response code: " + response.getStatus());
+            }
+            if (logger.isDebugEnabled()) {
+                logger.debug("Failed message:" + response.getBody());
+            }
+        }
+        return true;
     }
 
     private static String dirnameFor(final GenericFile file) {