Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made it responsive #14

Closed
wants to merge 2 commits into from
Closed

Made it responsive #14

wants to merge 2 commits into from

Conversation

jhanvi831
Copy link

@jhanvi831 jhanvi831 commented Dec 25, 2021

made navigation bar responsive

This PR fixes #12

link: https://jhanvi831.github.io/apple.com/

Signed commits

  • Yes, I signed my commits.

@FidalMathew
Copy link
Owner

@jhanvi831, I like the onClick effect even though it's a bit different than the original one.
But the alignment is a problem.
image

image

Earlier one -
image
and
yours-
image

I would also suggest you not change the font. Let's keep it as close to original as possible :)

@jhanvi831
Copy link
Author

I'll make the necessary changes. Thank you !

@jhanvi831 jhanvi831 closed this Jan 11, 2022
@jhanvi831 jhanvi831 mentioned this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Navbar CSS code
2 participants