sc-264935: Only require ACCESS_TRANSFER to approve/reject #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #264935: Update RMT to require transfer permissions instead of admin. |
jtalis
previously approved these changes
Oct 24, 2023
tsilva-figure
previously approved these changes
Oct 24, 2023
tbrooks-figure
dismissed stale reviews from tsilva-figure and jtalis
via
ae8e452
jtalis
approved these changes
Oct 25, 2023
tbrooks-figure
deleted the
tbrooks-figure/sc-264935/require-transfer-permission
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we will not be able to have
ACCESS_ADMINon IBC markers after 1.17, change to only check forACCESS_TRANSFERfor the account that is trying to approve/reject transfers.Ran the tests in
service-cap-table-contractagainst the new wasm to validate.